You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From what I can tell, the first example on the README is broken and omits required props that will fail if used as is. This might be a point of confusion for new users, as it was for me.
icon, onPress, selected are all required props but are missing from the example, perhaps they could be added in?
I think the main point of this issue is not valid anymore because of all the evolution made on the TabBarIOS and UIExplorer project. so this issue can be closed
I also think, as @danawoodman did, that this first example of the website lack a lot of things to not confuse new users: see this other issue #759
Summary:
Added bool config to YGConfig to configure using web defaults. See #445.
Closesfacebook/yoga#449
Reviewed By: astreet
Differential Revision: D4642272
Pulled By: emilsjolander
fbshipit-source-id: 4f35bd17b7f764f42295052a4a8b4ae46c192d7e
facebook
locked as resolved and limited conversation to collaborators
May 29, 2018
From what I can tell, the first example on the README is broken and omits required props that will fail if used as is. This might be a point of confusion for new users, as it was for me.
icon
,onPress
,selected
are all required props but are missing from the example, perhaps they could be added in?https://github.com/facebook/react-native/blob/72d3d724a3a0c6bc46981efd0dad8f7f61121a47/Libraries/Components/TabBarIOS/TabBarItemIOS.ios.js
The text was updated successfully, but these errors were encountered: