Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First example on README is broken #445

Closed
danawoodman opened this issue Mar 29, 2015 · 2 comments
Closed

First example on README is broken #445

danawoodman opened this issue Mar 29, 2015 · 2 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@danawoodman
Copy link

From what I can tell, the first example on the README is broken and omits required props that will fail if used as is. This might be a point of confusion for new users, as it was for me.

icon, onPress, selected are all required props but are missing from the example, perhaps they could be added in?

https://github.com/facebook/react-native/blob/72d3d724a3a0c6bc46981efd0dad8f7f61121a47/Libraries/Components/TabBarIOS/TabBarItemIOS.ios.js

@kennydee
Copy link
Contributor

Got the same problem, and it confused me, also because i can't find a good way to deal with the icon field.

The example in the UIExplorer project is pretty strange with the _ix_DEPRECATED function call :)
https://github.com/facebook/react-native/blob/master/Examples/UIExplorer/TabBarExample.js

So i also think, a quick fix + clarification on this example should help new users.

Thanks

@kennydee
Copy link
Contributor

I think the main point of this issue is not valid anymore because of all the evolution made on the TabBarIOS and UIExplorer project. so this issue can be closed

I also think, as @danawoodman did, that this first example of the website lack a lot of things to not confuse new users: see this other issue #759

facebook-github-bot pushed a commit that referenced this issue Mar 3, 2017
Summary:
Added bool config to YGConfig to configure using web defaults. See #445.
Closes facebook/yoga#449

Reviewed By: astreet

Differential Revision: D4642272

Pulled By: emilsjolander

fbshipit-source-id: 4f35bd17b7f764f42295052a4a8b4ae46c192d7e
@facebook facebook locked as resolved and limited conversation to collaborators May 29, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

4 participants