Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch react-native to use core-js (more specifically core-js Promise) #4142

Closed
burgalon opened this issue Nov 15, 2015 · 1 comment
Closed
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@burgalon
Copy link
Contributor

Currenttly react-native is using then/Promises which is missing reporting of unhandled exception/rejected promises.
This important feature is available in core-js which seems to work fine with JSC though I'm not seeing any official notes on compatibility.
I was able to just use npm i --save core-js and do import 'core-js' in order to run over the react-native polyfill.

I would love to try and turn this into a pull request unless there's something I'm missing here

davidaurelio added a commit that referenced this issue Jan 7, 2016
Summary:
Adds support for tracking unhandled rejections with `console.warn` (= yellow box).

I will create a follow-up with proper error stack formatting.

related: #4971
fixes: #4045, #4142

public

{F59857438}

{F59857439}

Reviewed By: bestander

Differential Revision: D2803126

fb-gh-sync-id: 376b33e42a967675a04338cbff3ec315a77d1037
@davidaurelio
Copy link
Contributor

Addressed in b064094

christopherdro pushed a commit to wildlifela/react-native that referenced this issue Jan 20, 2016
Summary:
Adds support for tracking unhandled rejections with `console.warn` (= yellow box).

I will create a follow-up with proper error stack formatting.

related: facebook#4971
fixes: facebook#4045, facebook#4142

public

{F59857438}

{F59857439}

Reviewed By: bestander

Differential Revision: D2803126

fb-gh-sync-id: 376b33e42a967675a04338cbff3ec315a77d1037
@facebook facebook locked as resolved and limited conversation to collaborators Jul 20, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

3 participants