Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActionSheetIOS text tint color #3374

Closed
iSimar opened this issue Oct 13, 2015 · 2 comments
Closed

ActionSheetIOS text tint color #3374

iSimar opened this issue Oct 13, 2015 · 2 comments
Labels
Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Platform: iOS iOS applications. Resolution: Locked This issue was locked by the bot.

Comments

@iSimar
Copy link

iSimar commented Oct 13, 2015

Enhancement Suggestion - text tint color prop for ActionSheetIOS
@javache javache added Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Platform: iOS iOS applications. labels Oct 13, 2015
@admmasters
Copy link
Contributor

Hmmm - we should probably look at changing ActionSheetIOS's current implementation as it currently relies on UIActionSheet which was deprecated in iOS8. https://developer.apple.com/library/prerelease/ios/documentation/UIKit/Reference/UIActionSheet_Class/index.html changing the tint colour is trivial if we rely upon UIAlertController instead.

@christopherdro
Copy link
Contributor

@admmasters Actionsheet with UIAlertcontroller has been implemented.

I played around a bit with setting the tint color on both action sheet and alert and it seems fairly straightforward. Just need to find a good way to expose this as props.

If anyone else manages to tackle this before me, make sure to set the tintColor AFTER presenting the view to the user. If not, the highlight tint of the buttons defaults back to blue regardless of the custom tintColor set.

christopherdro added a commit to christopherdro/react-native that referenced this issue Dec 6, 2015
@christopherdro
[ActionSheetIOS] Add tintColor for buttons.
e800259 
Closes facebook#3374
@christopherdro christopherdro mentioned this issue Dec 6, 2015
Closed
christopherdro added a commit to christopherdro/react-native that referenced this issue Dec 6, 2015
@christopherdro
[ActionSheetIOS] Add tintColor for buttons.
9b3e995 
Closes facebook#3374
christopherdro added a commit to christopherdro/react-native that referenced this issue Dec 7, 2015
@christopherdro
[ActionSheetIOS] Add tintColor for buttons.
b0106dc 
Closes facebook#3374
christopherdro added a commit to christopherdro/react-native that referenced this issue Dec 7, 2015
@christopherdro
[ActionSheetIOS] Add tintColor for buttons.
54cda40 
Closes facebook#3374
rozele referenced this issue in microsoft/react-native-windows May 25, 2016
@christopherdro
Add tintColor for buttons.
eb4bc81 
Summary:
Closes #3374
Closes facebook/react-native#4590

Reviewed By: javache

Differential Revision: D2729616

Pulled By: mkonicek

fb-gh-sync-id: 4a3b6de10a09cad73dbd9d5d552adc3f6ba054e0
@facebook facebook locked as resolved and limited conversation to collaborators Jul 21, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Platform: iOS iOS applications. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@javache @admmasters @christopherdro @iSimar @react-native-bot