Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary files should be stored in ~/LIbrary/Caches or elsewhere, not ~/.rncache #21780

Closed
sryze opened this issue Oct 14, 2018 · 8 comments
Closed

Temporary files should be stored in ~/LIbrary/Caches or elsewhere, not ~/.rncache #21780

sryze opened this issue Oct 14, 2018 · 8 comments
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.

Comments

@sryze
Copy link
Contributor

sryze commented Oct 14, 2018 •
edited
Loading

Environment

  React Native Environment Info:
    System:
      OS: macOS High Sierra 10.13.6
      CPU: (4) x64 Intel(R) Core(TM) i5-7500 CPU @ 3.40GHz
      Memory: 612.74 MB / 16.00 GB
      Shell: 5.6.2 - /usr/local/bin/zsh
    Binaries:
      Node: 11.4.0 - /usr/local/bin/node
      Yarn: 1.12.3 - /usr/local/bin/yarn
      npm: 6.4.1 - /usr/local/bin/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    SDKs:
      iOS SDK:
        Platforms: iOS 12.1, macOS 10.14, tvOS 12.1, watchOS 5.1
    IDEs:
      Android Studio: 3.2 AI-181.5540.7.32.5056338
      Xcode: 10.1/10B61 - /usr/bin/xcodebuild
    npmPackages:
      react: ^16.6.3 => 16.6.3
      react-native: 0.57.2 => 0.57.2
    npmGlobalPackages:
      create-react-native-app: 1.0.0
      react-native-cli: 2.0.1

Description

Why does React Native put downloaded source code archives (e.g. Boost, glog) in ~/.rncache? I don't want to track down the temporary garbage created by react-native next time I need to make more free disk space.

Please put these files in ~/Library/Caches or /tmp (or some other appropriate directory) on macOS.

Reproducible Demo

Just run react-native init ProjectName and build the iOS app.
@sryze sryze closed this as completed Oct 14, 2018
@mcchrish
Copy link

I mean this seems to be a good point, and to not pollute the home directory. Why did you close the issue?

@sryze
Copy link
Contributor Author

sryze commented Dec 15, 2018

Reopened

I don't remember why I closed it, probably looked at the number of already open issues/PRs and thought nobody would care about such a small thing

@sryze sryze reopened this Dec 15, 2018
@react-native-bot
Copy link
Collaborator

We are automatically closing this issue because it does not appear to follow any of the provided issue templates.

Please make use of the bug report template to let us know about a reproducible bug or regression in the core React Native library.

If you'd like to propose a change or discuss a feature request, there is a repository dedicated to Discussions and Proposals you may use for this purpose.

@react-native-bot react-native-bot added Ran Commands One of our bots successfully processed a command. 📋No Template labels Dec 15, 2018
@sryze
Copy link
Contributor Author

sryze commented Dec 15, 2018

I filled the template but I don't know how to reopen, sorry

@mcchrish
Copy link

Maybe let's ping @hramos?

@mcchrish
Copy link

Another suggestion is using $XDG_CACHE_HOME based on xdg directories.

@hramos
Copy link
Contributor

hramos commented Dec 17, 2018

In this case, I think it's best to just send a PR.

sryze added a commit to sryze/react-native that referenced this issue Dec 18, 2018
@sryze
Change location of iOS build cache directory to ~/Library/Caches/
63d784b 
Instead of using ~/.rncache use the special Caches directory designed
for caching files. This fixes facebook#21780.
@sryze sryze mentioned this issue Dec 18, 2018
Closed
@sryze
Copy link
Contributor Author

sryze commented Dec 18, 2018

I opened a pull request, please review: #22688

sryze added a commit to sryze/react-native that referenced this issue Dec 19, 2018
@sryze
Reuse old cache directory if already exists (facebook#21780)
4150169
facebook-github-bot pushed a commit that referenced this issue Jan 25, 2019
@sryze @facebook-github-bot
Change location of iOS build cache directory to ~/Library/Caches/ (#2…
1024dc2 
…2688)

Summary:
Instead of using ~/.rncache use the special Caches directory designed for caching files. This fixes #21780.

Changelog:
----------

[iOS] [Changed] - Moved iOS build cache directory from ~/.rncache to ~/Library/Caches/com.facebook.ReactNativeBuild
Pull Request resolved: #22688

Differential Revision: D13817171

Pulled By: cpojer

fbshipit-source-id: af03dda66f9d49f4fe88bd050b359ccb7abb889a
matt-oakes pushed a commit to matt-oakes/react-native that referenced this issue Feb 7, 2019
@sryze @facebook-github-bot
Change location of iOS build cache directory to ~/Library/Caches/ (fa…
2610ba5 
…cebook#22688)

Summary:
Instead of using ~/.rncache use the special Caches directory designed for caching files. This fixes facebook#21780.

Changelog:
----------

[iOS] [Changed] - Moved iOS build cache directory from ~/.rncache to ~/Library/Caches/com.facebook.ReactNativeBuild
Pull Request resolved: facebook#22688

Differential Revision: D13817171

Pulled By: cpojer

fbshipit-source-id: af03dda66f9d49f4fe88bd050b359ccb7abb889a
@facebook facebook locked as resolved and limited conversation to collaborators Dec 15, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Dec 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change location of iOS build cache directory to ~/Library/Caches/ sryze/react-native
4 participants
@hramos @sryze @mcchrish @react-native-bot