Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextInput capitalized all letter i's when there's an emoji before the text #20908

Closed
2 tasks done
dchersey opened this issue Aug 29, 2018 · 7 comments
Closed
2 tasks done
Labels
Bug Component: TextInput Related to the TextInput component. Resolution: Locked This issue was locked by the bot.

Comments

@dchersey
Copy link
Contributor

dchersey commented Aug 29, 2018

Environment

React Native Environment Info:
System:
OS: macOS High Sierra 10.13.6
CPU: x64 Intel(R) Core(TM) i7-4980HQ CPU @ 2.80GHz
Memory: 705.27 MB / 16.00 GB
Shell: 5.3 - /bin/zsh
Binaries:
Node: 9.11.1 - ~/.nvm/versions/node/v9.11.1/bin/node
Yarn: 1.9.2 - /usr/local/bin/yarn
npm: 5.6.0 - ~/.nvm/versions/node/v9.11.1/bin/npm
Watchman: 4.7.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 11.4, macOS 10.13, tvOS 11.4, watchOS 4.3
Android SDK:
Build Tools: 23.0.1, 23.0.2, 25.0.0, 25.0.2, 25.0.3, 26.0.1, 26.0.3, 27.0.0, 27.0.3, 28.0.0
API Levels: 23, 24, 25, 26, 27
IDEs:
Android Studio: 3.0 AI-171.4443003
Xcode: 9.4.1/9F2000 - /usr/bin/xcodebuild
npmPackages:
react: 16.4.1 => 16.4.1
react-native: 0.56.0 => 0.56.0
npmGlobalPackages:
react-native-cli: 2.0.1

Description

TextInput capitalizes all letter I's within words when there's an emoji to the left of the characters and you are editing in the middle of a sentence.

See #19389 for more context

Reproducible Demo

When you have an emoji as the last character of your text input and then move the text cursor back (still with emoji as last character) and enter new letters somewhere in the middle of the string. It only capitalizes the letter i. This also happens if you start your text with an emoji, then type some words, then go back in and start editing text; all i's will be capitalized, even in the middle of words.

@react-native-bot react-native-bot added the Component: TextInput Related to the TextInput component. label Aug 29, 2018
@react-native-bot
Copy link
Collaborator

Can you run react-native info and edit your issue to include these results under the Environment section?

If you believe this information is irrelevant to the reported issue, you may write [skip envinfo] under Environment to let us know.

@Balasnest
Copy link

Facing everywhere in textInput component. I tried adding autoCaptialize = {none} with some of the textInput. It seems to be working. But all the i's letter are caps still.

Is there any way to fix without updating / changing react native version ?

  OS: macOS High Sierra 10.13
  Node: 8.9.4
  Yarn: 1.3.2
  npm: 4.6.1
  Watchman: 4.9.0
  Xcode: Xcode 9.2 Build version 9C40b
  Android Studio: 3.0 AI-171.4443003

Packages: (wanted => installed)
  react: 16.3.1 => 16.3.1
  react-native: 0.54.4 => 0.54.4

@superandrew213
Copy link

superandrew213 commented Sep 20, 2018

Having this issue too on IOS since updating to RN0.56.

Also when enabling multiline and there is an emoji in the text:

  • All letters go all caps sometimes.
  • Adding new lines behaves glitchy when there is an emoji and it is out of view.
  • Auto correct suggestions also don't match the word being typed sometimes

Upgraded to RN0.57 and the issue is still there.

@Balasnest
Copy link

Anybody get solution for this?

@petekp
Copy link

petekp commented Oct 23, 2018

We've received reports about this issue from our users — we're on RN 0.55. It's difficult to reproduce but seems to occur mostly around the letter i which begins to automatically capitalize when editing text or entering a new word between existing words; the shift key starts to have a mind of its own. It's possible to get into a state where all subsequently entered words are capitalized automatically.

To be clear, this is reproducible without any emojis present.

Here is how we have <TextInput> configured:

<TextInput
 multiline
 autoCapitalize="sentences"
 autoCorrect
 spellCheck
 autoGrow
 style={styles.messageInput}
 value={this.state.input}
 placeholder={inputPlaceholderText}
 onChangeText={input => this.setState({ input })}
/>

@hramos hramos removed the Bug Report label Feb 6, 2019
matt-oakes pushed a commit to matt-oakes/react-native that referenced this issue Feb 7, 2019
…dited. (facebook#21951)

Summary:
Fixes facebook#21243.
Fixes facebook#20908.

Credit goes to superandrew213 who provided the patch based on 0.56; this commit merges and resolved the conflict introduced in 0.57.
Pull Request resolved: facebook#21951

Differential Revision: D13980799

Pulled By: cpojer

fbshipit-source-id: 6b9f1a1ae54ad9dba043005d683d6a221472c729
grabbou pushed a commit that referenced this issue Feb 18, 2019
…dited. (#21951)

Summary:
Fixes #21243.
Fixes #20908.

Credit goes to superandrew213 who provided the patch based on 0.56; this commit merges and resolved the conflict introduced in 0.57.
Pull Request resolved: #21951

Differential Revision: D13980799

Pulled By: cpojer

fbshipit-source-id: 6b9f1a1ae54ad9dba043005d683d6a221472c729
@TheRohitSharma
Copy link

TheRohitSharma commented Mar 7, 2019

@petekp Have you seen any progress regarding this issue? Our users have reported it as well, and I can reproduce it by ending a sentence with a period and then a space, and then going back to the middle of some text and typing. Every letter comes out capitalized.

Also on version 0.55, though you may no longer be.

@dchersey
Copy link
Contributor Author

dchersey commented Mar 7, 2019

We've had this patch in production for a while; it definitively solved the issue. Patch is relatative to RN 0.57+.
#21243 (comment)

The associated PR has been merged to master ... no info on when it will be released though.

t-nanava pushed a commit to microsoft/react-native-macos that referenced this issue Jun 17, 2019
…dited. (facebook#21951)

Summary:
Fixes facebook#21243.
Fixes facebook#20908.

Credit goes to superandrew213 who provided the patch based on 0.56; this commit merges and resolved the conflict introduced in 0.57.
Pull Request resolved: facebook#21951

Differential Revision: D13980799

Pulled By: cpojer

fbshipit-source-id: 6b9f1a1ae54ad9dba043005d683d6a221472c729
@facebook facebook locked as resolved and limited conversation to collaborators Feb 7, 2020
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Feb 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Component: TextInput Related to the TextInput component. Resolution: Locked This issue was locked by the bot.
Projects
None yet
7 participants