-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.51] Commits to cherry-pick into stable release #16614
Comments
Would be amazing if this was addressed: #10999 |
Please keep this list to critical bug fixes that are new in 0.51 and ideally have been merged into master -- post commit hashes rather than issue/PR numbers unless the issue/PR in question targets a problem specific to 0.51. The intent of these cherry-pick threads is not to solicit features but to fix things that make 0.51 substantially more launch-blocked than 0.50. This is an example of an appropriate PR, which fixes the Podspec so 0.51 compiles: #16664 Cherry-picked 2a24b7b (Podspec fix) and a follow-up commit into 0.51-stable. |
For next issue template, I'll probably include this as a default issue description.
|
Right now 0.51.0-rc.0 is not out yet on |
@svbutko and @robblovell, PRs that you have linked are not yet merged into master and I don't see how they could be critical to this release. I've deleted other, not related comments in this thread. Please keep it to the point and post comments as per @ide guidelines. |
@charpeni I see that the commit you have nominated is more a minor feature rather than a hotfix. Would you mind providing a bit more context as to why you would like this one to be cherry-picked? |
ee3532b - Without this fix, our logs in iOS are spamed with this warning:
b9e7006 - Nit picking in the previous warning message, can be omitted. |
That tvOS change looks safe to me, cherry-picked both of those commits (please help test if you can!) Also added 0bef872 which fixes autoscrolling to the cursor in Android multiline text inputs. |
Can we cherry-pick this? |
Done and releasing as an release candidate 3. This version will be promoted to stable tomorrow along with the changelog that we have in place. |
Does that mean we should expect to see 0.51.0 stable release (non-RC) available in NPM by end of the week? Currently the previous 0.51.0 RC-1 and RC-2 versions are not released in NPM. The latest is still 0.50.4. |
Yes. Today, to be precise.
Here's the CI pipeline of RC:
https://circleci.com/workflow-run/4d60244c-50e7-47a6-97f1-31a37e7e370f where
you can see its deploy progress.
…On Thu, 30 Nov 2017 at 19:05 hey99xx ***@***.***> wrote:
Does that mean we should expect to see 0.51.0 stable release (non-RC)
available in NPM by end of the week? Currently the previous 0.51.0 RC-1 and
RC-2 versions are not released in NPM. The latest is still 0.50.4.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#16614 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACWcxiIHf9LepMJ-klfPKI5C7BFqxflFks5s7u5WgaJpZM4QMpSy>
.
|
So, what's with that? |
It seems that 0.51.0-rc.3 is not released in NPM yet, please help 😄 |
@grabbou , this pipeline info brings not much if we can see that it stuck on hold for few days ;) I see there is 0.51.0-rc.2 on npm, ok, it's all about 51-RC for now. |
This particular build has been on hold because of CircleCI issues. I tried
enabling it many times to "pass" the release, but it didn't work (they had
outage).
I'll just go ahead and release a stable version in the afternoon today.
…On Mon, 4 Dec 2017 at 02:38 chrusart ***@***.***> wrote:
@grabbou <https://github.com/grabbou> , this pipeline info brings not
much if we can see that it stuck on hold for few days ;)
So, why still on hold?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16614 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACWcxqzIb2xXQYZJ89IhpbO9-MKADmgaks5s88uQgaJpZM4QMpSy>
.
|
Actually, I managed to make it run this time ->
https://circleci.com/gh/facebook/react-native/27792
…On Mon, 4 Dec 2017 at 07:33 Mike Grabowski ***@***.***> wrote:
This particular build has been on hold because of CircleCI issues. I tried
enabling it many times to "pass" the release, but it didn't work (they had
outage).
I'll just go ahead and release a stable version in the afternoon today.
On Mon, 4 Dec 2017 at 02:38 chrusart ***@***.***> wrote:
> @grabbou <https://github.com/grabbou> , this pipeline info brings not
> much if we can see that it stuck on hold for few days ;)
> So, why still on hold?
>
> —
> You are receiving this because you were mentioned.
>
>
> Reply to this email directly, view it on GitHub
> <#16614 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ACWcxqzIb2xXQYZJ89IhpbO9-MKADmgaks5s88uQgaJpZM4QMpSy>
> .
>
|
@grabbou is 0.51.0 supposed to be available in npm right now? I only see 0.50.4 still. It shows success in your circleci link but I'm not exactly sure what this entails. Sorry if I'm jumping the gun and thanks for your time. |
@jslok it's 0.51.0-rc.3 build for now. It's on npm. |
0.51.0-rc.3 seems like the best option for now since stable release isn't up yet. Wondering where the best place is to look at a change log @grabbou ? Thanks! |
Stable is out, you can see the changelog in the "Releases" tab on Github :)
…On Tue, 5 Dec 2017 at 11:59 Richard Girges ***@***.***> wrote:
0.51.0-rc.3 seems like the best option for now since stable release isn't
up yet. Wondering where the best place is to look at a change log @grabbou
<https://github.com/grabbou> ? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16614 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACWcxkvJVffi_MejFcBpbIK-vdSer9s_ks5s9aC-gaJpZM4QMpSy>
.
|
@grabbou in stable, flowconfig is set for version 0.57.0 there is no such version. Only 0.57.1 or .2 or .3. when I do |
I'm late to this but if my analysis is correct, #17030 seems to be a serious regression that should be fixed in v0.51. |
Subscribed and will be awaiting status. For now, going to close this one as no cherry-picks to stable anymore except the bug fixes that we will track separately. |
Going to roll out |
The thread containing issues that are blocking 0.51 release and need to be addressed.
Before posting your comment, please read the below quote by @ide:
The text was updated successfully, but these errors were encountered: