Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsSchedulingOverhead warnings #1598

Closed
jaygarcia opened this issue Jun 11, 2015 · 21 comments
Closed

jsSchedulingOverhead warnings #1598

jaygarcia opened this issue Jun 11, 2015 · 21 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@jaygarcia
Copy link
Contributor

I'm quite embarrassed to say that I'm finally getting around to debugging my JSX code on the phone.

I'm getting these jsSchedulingOverhead warnings:

jsschedulingoverhead

Should I be worried? Could it be caused by the fact that I'm debugging w/ chrome?

@tadeuzagallo
Copy link
Contributor

What it means is that the start date passed on the timer creation (Date.now() on JavaScript) is 800ms ahead of the current time on iOS ([NSDate now]), when you're running the app on the device and the executor on your computer it's very unlikely that the times will be the same at the millisecond level. So no, don't worry about it.

@siwymilek
Copy link

How can I not worry about though warrnings obscure a half of screen and I can't disable them...

@tadeuzagallo
Copy link
Contributor

I don't know if you realise, but this issue is from 6 months ago, and at the time there were no YellowBox, but yes, you can disable them, try:

console.ignoreYellowBox = ['jsSchedulingOverhead'];

@nicklockwood maybe we should remove this warning?

@nicklockwood
Copy link
Contributor

@tadeuzagallo I've no context on what this warning means, but it seems very spammy. Maybe YellowBox should have an upper limit on warnings displayed at once?

@mvayngrib
Copy link
Contributor

@tadeuzagallo looks like it's console.ignoredYellowBox not console.ignoreYellowBox

@lfsanchezg
Copy link

pasted console.ignoredYellowBox = ['jsSchedulingOverhead']; on my code and it worked on the phone, but Xcode still shows the warning.

captura de pantalla 2016-01-07 a las 6 20 25 p m

Do you have any workaround for this? for now I put my computer some seconds behind.

@eysi09
Copy link

eysi09 commented Jan 18, 2016

This warning is clogging up my Chrome console, repeating indefinitely and obscuring all relevant console logs. Is there any way around this except changing the computer's cloclk? console.ignoredYellowBox = ['jsSchedulingOverhead']; only removes the warning from the phone, not the Chrome or Xcode consoles.

@lrettig
Copy link
Contributor

lrettig commented Jan 19, 2016

+1

This is happening to me too, and making debugging while running on a device impossible. Why is this request closed? We need a way to disable these warnings in Chrome/Xcode too.

It's clearly affecting a bunch of other people, cf: root-two/react-native-drawer#44, #2046, react-native-camera/react-native-camera#32, #5136 etc.

Thanks

@lrettig
Copy link
Contributor

lrettig commented Jan 19, 2016

Temporary workaround: comment out line 179 of React/Modules/RCTTiming.m

image

@marcboehret
Copy link

+1

@corbt
Copy link
Contributor

corbt commented Jan 27, 2016

Re-opening because this is a common problem when developing on a device.

@corbt corbt reopened this Jan 27, 2016
@aakashsigdel
Copy link

+1

@ryantbd
Copy link

ryantbd commented Jan 29, 2016

+1. Seems commenting out that line is the only effective way to remove the warning. by @lrettig #1598 (comment)

@prabakarviji
Copy link
Contributor

+1

1 similar comment
@sjmueller
Copy link
Contributor

+1

@corbt
Copy link
Contributor

corbt commented Feb 11, 2016

I agree with everyone that this is an annoying issue developing on a device. I've pushed a possible fix in #5731, will try to poke some people at Facebook to review the change.

@leijing7
Copy link

@lrettig your commenting out method works well

@kennym
Copy link

kennym commented Feb 21, 2016

+1

1 similar comment
@elaygl
Copy link

elaygl commented Mar 2, 2016

+1

@bcalik
Copy link
Contributor

bcalik commented Mar 5, 2016

Wow this is a year old simple issue and still has no progress!

ghost pushed a commit that referenced this issue Mar 5, 2016
Summary:This commit modifies the jsSchedulingOverhead warning to only fire if the JS clock is more than 5 seconds ahead of the native clock. This fixes the issue in #1598 for the common case when there's only a minor difference between the two clocks, while still keeping a sanity check if they're extremely off.

cc nicklockwood tadeuzagallo
Closes #5731

Differential Revision: D3014985

Pulled By: tadeuzagallo

fb-gh-sync-id: bf57e48b7d97ad02d2aefb6e5aac845824a6fdb0
shipit-source-id: bf57e48b7d97ad02d2aefb6e5aac845824a6fdb0
@corbt
Copy link
Contributor

corbt commented Mar 5, 2016

Warning removed in 2d27cf0. Sorry that took so long!

@corbt corbt closed this as completed Mar 5, 2016
pglotov pushed a commit to pglotov/react-native that referenced this issue Mar 15, 2016
Summary:This commit modifies the jsSchedulingOverhead warning to only fire if the JS clock is more than 5 seconds ahead of the native clock. This fixes the issue in facebook#1598 for the common case when there's only a minor difference between the two clocks, while still keeping a sanity check if they're extremely off.

cc nicklockwood tadeuzagallo
Closes facebook#5731

Differential Revision: D3014985

Pulled By: tadeuzagallo

fb-gh-sync-id: bf57e48b7d97ad02d2aefb6e5aac845824a6fdb0
shipit-source-id: bf57e48b7d97ad02d2aefb6e5aac845824a6fdb0
@facebook facebook locked as resolved and limited conversation to collaborators Jul 22, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests