Not documented AdSupportIOS

[kwef]

Description

I had to add the RCTAdSupport.h and RCTAdSupport.m files to XCode to manually link to react native in order to get AdSupportIOS to stop throwing "undefined is not an object.... ". There ought to be better documentation for this.

• React Native version: [0.41.2]
• Platform: [iOS]
• Operating System: [MacOs]

[hramos]

Can you elaborate?

[kwef]

Sure. In order to get AdSupportIOS to work, I had to manually add files to Xcode. I feel like this wasn't clear that it was required to somehow manually link files, as the documentation about AdSupportIOS currently says nothing about this: https://facebook.github.io/react-native/docs/adsupportios.html.

[hramos]

Would you be willing to open a PR to add the necessary steps missing from that file?

Otherwise, can you comment on this issue with the exact list of steps you had to take in order to use AdSupportIOS.

[kwef]

I can open a PR. Where's the best place/file to do that?

[hramos]

You would need to add comments to the source file at https://github.com/facebook/react-native/blob/master/Libraries/AdSupport/AdSupportIOS.js. You can take a look at other APIs to see how these comments should be formatted.

[kwef]

Is there anything else that I need to do here, or is the PR all set?

…

On Wed, Mar 1, 2017 at 6:16 PM, Héctor Ramos ***@***.***> wrote: You would need to add comments to the source file at https://github.com/facebook/react-native/blob/master/Libraries/AdSupport/ AdSupportIOS.js. You can take a look at other APIs to see how these comments should be formatted. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#12623 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFQ8oDSuE3g6Db4jFkqNoy8vtsw-Ut8bks5rhfxagaJpZM4MOxWF> .