Add more information in ending Marker Tags

Summary: Added more information to ending tags so that they can be connected with the starting tags. Reviewed By: mdvacca Differential Revision: D7121038 fbshipit-source-id: 72d51952955e22a4c8d66c4f9e75a3fd9d34df7f
facebook · Nov 30, 2018 · fe97458 · fe97458
1 parent 8d68a3e
commit fe97458
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/ReactAndroid/src/main/java/com/facebook/react/bridge/JavaModuleWrapper.java b/ReactAndroid/src/main/java/com/facebook/react/bridge/JavaModuleWrapper.java
@@ -141,10 +141,10 @@ public List<MethodDescriptor> getMethodDescriptors() {
     try {
       return Arguments.makeNativeMap(map);
     } finally {
-      ReactMarker.logMarker(CONVERT_CONSTANTS_END);
+      ReactMarker.logMarker(CONVERT_CONSTANTS_END, moduleName);
       Systrace.endSection(TRACE_TAG_REACT_JAVA_BRIDGE);
 
-      ReactMarker.logMarker(GET_CONSTANTS_END);
+      ReactMarker.logMarker(GET_CONSTANTS_END, moduleName);
       SystraceMessage.endSection(TRACE_TAG_REACT_JAVA_BRIDGE).flush();
     }
   }

diff --git a/ReactAndroid/src/main/java/com/facebook/react/bridge/ModuleHolder.java b/ReactAndroid/src/main/java/com/facebook/react/bridge/ModuleHolder.java
@@ -192,7 +192,7 @@ private NativeModule create() {
         doInitialize(module);
       }
     } finally {
-      ReactMarker.logMarker(CREATE_MODULE_END, mInstanceKey);
+      ReactMarker.logMarker(CREATE_MODULE_END, mName ,mInstanceKey);
       SystraceMessage.endSection(TRACE_TAG_REACT_JAVA_BRIDGE).flush();
     }
     return module;
@@ -222,7 +222,7 @@ private void doInitialize(NativeModule module) {
         }
       }
     } finally {
-      ReactMarker.logMarker(ReactMarkerConstants.INITIALIZE_MODULE_END, mInstanceKey);
+      ReactMarker.logMarker(ReactMarkerConstants.INITIALIZE_MODULE_END, mName, mInstanceKey);
       SystraceMessage.endSection(TRACE_TAG_REACT_JAVA_BRIDGE).flush();
     }
   }