make getModuleClassFromName: required (#36968)

Summary:
Pull Request resolved: #36968

Changelog: [iOS][Breaking]

we should be using `optional` never. this will be a breaking change if you have any class that conform to `RCTTurboModuleManagerDelegate`

#saynotoruntimechecks

Reviewed By: cipolleschi

Differential Revision: D45022003

fbshipit-source-id: d1b3cf72bae82070704f20de4558949189da462a

packages/react-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModuleManager.h

@@ -19,13 +19,13 @@ RCT_EXTERN void RCTTurboModuleSetBindingMode(facebook::react::TurboModuleBinding
 
 @protocol RCTTurboModuleManagerDelegate <NSObject>
 
-@optional
-
 /**
- * Given a module name, return its actual class. If not provided, basic ObjC class lookup is performed.
+ * Given a module name, return its actual class. If nil is returned, basic ObjC class lookup is performed.
  */
 - (Class)getModuleClassFromName:(const char *)name;
 
+@optional
+
 /**
  * Given a module class, provide an instance for it. If not provided, default initializer is used.
  */

packages/react-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModuleManager.mm

@@ -388,14 +388,11 @@ - (TurboModuleHolder *)_getOrCreateTurboModuleHolder:(const char *)moduleName
     /**
      * Step 2a: Resolve platform-specific class.
      */
-
-    if ([_delegate respondsToSelector:@selector(getModuleClassFromName:)]) {
-      if (RCTTurboModuleManagerDelegateLockingDisabled()) {
-        moduleClass = [_delegate getModuleClassFromName:moduleName];
-      } else {
-        std::lock_guard<std::mutex> delegateGuard(_turboModuleManagerDelegateMutex);
-        moduleClass = [_delegate getModuleClassFromName:moduleName];
-      }
+    if (RCTTurboModuleManagerDelegateLockingDisabled()) {
+      moduleClass = [_delegate getModuleClassFromName:moduleName];
+    } else {
+      std::lock_guard<std::mutex> delegateGuard(_turboModuleManagerDelegateMutex);
+      moduleClass = [_delegate getModuleClassFromName:moduleName];
     }
 
     if (!moduleClass) {