Skip to content

Commit

Permalink
Fix compilation warnings introduced by Gradle 8.4 (#39959)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #39959

We're still accessing project.buildDir which will be removed in Gradle 9.0
I'm cleaning it up here.

Changelog:
[Internal] [Changed] - Fix compilation warnings introduced by Gradle 8.4

Reviewed By: yungsters

Differential Revision: D50016573

fbshipit-source-id: de7a725f61b503f08991ebf85b9a002cefab221a
  • Loading branch information
cortinico authored and facebook-github-bot committed Oct 6, 2023
1 parent 81213f6 commit e9ecd35
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions packages/react-native-gradle-plugin/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ tasks.withType<KotlinCompile>().configureEach {
apiVersion = "1.5"
// See comment above on JDK 11 support
jvmTarget = "11"
allWarningsAsErrors = true
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ internal fun Project.configureReactTasks(variant: Variant, config: ReactExtensio
val targetName = variant.name.capitalizeCompat()
val targetPath = variant.name

val buildDir = this.layout.buildDirectory.get().asFile
// Resources: generated/assets/react/<variant>/index.android.bundle
val resourcesDir = File(buildDir, "generated/res/react/$targetPath")
// Bundle: generated/assets/react/<variant>/index.android.bundle
Expand Down

0 comments on commit e9ecd35

Please sign in to comment.