Skip to content

Commit

Permalink
Update 'react-native upgrade' to warn when 'react' is not found in a …
Browse files Browse the repository at this point in the history
…project's dependencies when the react-native version is >= 0.21.0.
  • Loading branch information
skevy committed Feb 8, 2016
1 parent 5f89716 commit c015d2a
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions local-cli/upgrade/upgrade.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,19 @@ module.exports = function upgrade(args, config) {
'https://github.com/facebook/react-native/releases/tag/v' + semver.major(v) + '.' + semver.minor(v) + '.0'
)
);

// >= v0.21.0, we require react to be a peer depdendency
if (semver.gte(v, '0.21.0') && !pak.dependencies['react']) {
console.log(
chalk.yellow(
'\nYour \'package.json\' file doesn\'t seem to have \'react\' as a dependency.\n' +
'\'react\' was changed from a dependency to a peer dependency in react-native v0.21.0.\n' +
'Therefore, it\'s necessary to include \'react\' in your project\'s dependencies.\n' +
'Just run \'npm install --save react\', then re-run \'react-native upgrade\'.\n'
)
);
return Promise.resolve();
}
} else {
console.log(
chalk.yellow(
Expand Down

0 comments on commit c015d2a

Please sign in to comment.