Skip to content

Commit

Permalink
Fix windows build of RectangleEdges (#35516)
Browse files Browse the repository at this point in the history
Summary:
[PR: Avoid emitting mountitems for default values](56e9aa3) used a constexpr in a template, which windows is unable to compile since type at this point is incomplete. Once removed, windows is able to build again. Let me know if there's a better way to fix this!

See [10072](microsoft/react-native-windows#10072) for windows error messages

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->
[General] [Fixed] - Remove constexpr from RectangleEdges.h

Pull Request resolved: #35516

Test Plan: Windows has forked this file and had the change for ~5 month, all tests pass on Windows side

Reviewed By: javache

Differential Revision: D41639514

Pulled By: rshest

fbshipit-source-id: fbe595f71a7ab0accb7a76edf58ffb6aeef1ae96
  • Loading branch information
TatianaKapos authored and facebook-github-bot committed Dec 1, 2022
1 parent 217696e commit 879d303
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ReactCommon/react/renderer/graphics/RectangleEdges.h
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ struct RectangleEdges {
};

template <typename T>
constexpr RectangleEdges<T> const RectangleEdges<T>::ZERO = {};
RectangleEdges<T> const RectangleEdges<T>::ZERO = {};

template <typename T>
RectangleEdges<T> operator+(
Expand Down

0 comments on commit 879d303

Please sign in to comment.