-
Notifications
You must be signed in to change notification settings - Fork 24.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
store borderColor in a non lossy way
Summary: Fix for issue #3652 - Converting from `int` to `float` is lossy for very large numbers, so storing `borderColor` as a single `Spacing` object (which uses `float`) was not working for certain colors. So, this pull request splits `borderColor` into alpha and RGB components, and stores each of these as their own respective `Spacing` objects. *Test Plan* Check out cosmith sample code here that triggers the bug: https://rnplay.org/apps/l1bw2A What currently looks like this: <img width="548" alt="screen shot 2016-08-13 at 6 22 28 pm" src="https://cloud.githubusercontent.com/assets/1630466/17645965/9346f05e-6183-11e6-8d40-3e458b08fd9a.png"> Should look like this (with my fix applied): <img width="543" alt="screen shot 2016-08-13 at 6 20 08 pm" src="https://cloud.githubusercontent.com/assets/1630466/17645968/9c26d1d0-6183-11e6-8759-75a5e99f498a.png"> Closes #9380 Differential Revision: D3716707 Pulled By: foghina fbshipit-source-id: 1164378112e2a58d43c8f5fc671c2efdb64b412b
- Loading branch information
Mani Ghasemlou
authored and
Facebook Github Bot 4
committed
Aug 15, 2016
1 parent
8240339
commit 8095707
Showing
3 changed files
with
55 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters