Skip to content

Commit

Permalink
Store test artifacts for Android (#37269)
Browse files Browse the repository at this point in the history
Summary:
We should store XML datas from the test we execute so when they fail it's easier to immediately see which test caused the failure.

## Changelog:

[INTERNAL] - Store test artifacts for Android

Pull Request resolved: #37269

Test Plan: Wait for CI results

Reviewed By: cipolleschi

Differential Revision: D45603973

Pulled By: cortinico

fbshipit-source-id: e818b353816e10b3e4ed16bdb66dd4c8918a9c51
  • Loading branch information
cortinico authored and facebook-github-bot committed May 5, 2023
1 parent a3b57f6 commit 758b740
Showing 1 changed file with 7 additions and 14 deletions.
21 changes: 7 additions & 14 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -724,10 +724,6 @@ jobs:
# -------------------------
test_android:
executor: reactnativeandroid
parameters:
run_disabled_tests:
type: boolean
default: false
steps:
- checkout
- setup_artifacts
Expand All @@ -741,18 +737,16 @@ jobs:
- report_bundle_size:
platform: android

- store_test_results:
path: ~/react-native/packages/react-native-gradle-plugin/build/test-results

- store_test_results:
path: ~/react-native/packages/react-native/ReactAndroid/build/test-results

- store_artifacts:
path: ~/react-native/packages/rn-tester/android/app/build/outputs/apk/
destination: rntester-apk

# Optionally, run disabled tests
- when:
condition: << parameters.run_disabled_tests >>
steps:
- run: echo "Failing tests may be moved here temporarily."
- run_e2e:
platform: android

# -------------------------
# JOBS: Test Android Docker Image
# -------------------------
Expand Down Expand Up @@ -1602,8 +1596,7 @@ workflows:
- build_hermesc_windows
- test_js:
run_disabled_tests: false
- test_android:
run_disabled_tests: false
- test_android
- test_android_docker_image
- test_android_template:
requires:
Expand Down

0 comments on commit 758b740

Please sign in to comment.