Skip to content

Commit

Permalink
Disabled unit tests that need yoga libs when running
Browse files Browse the repository at this point in the history 
Reviewed By: hramos

Differential Revision: D4346826

fbshipit-source-id: 70855a44b27d25e49615914a845cf04fc63e322d
  • Loading branch information
@bestander @facebook-github-bot
bestander authored and facebook-github-bot committed Dec 19, 2016
1 parent ede04ab commit 709a441
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
5 changes: 3 additions & 2 deletions ReactAndroid/src/test/java/com/facebook/react/uimanager/BUCK
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@ rn_robolectric_test(
name = 'uimanager',
# Please change the contact to the oncall of your team
contacts = ['[email protected]'],
srcs = glob(['**/*.java']),
# TODO Disabled temporarily until Yoga linking is fixed t14964130
# srcs = glob(['**/*.java']),
srcs = ['SimpleViewPropertyTest.java'],
deps = [
YOGA_TARGET,
react_native_dep('libraries/fbcore/src/test/java/com/facebook/powermock:powermock'),
Expand All @@ -30,4 +32,3 @@ rn_robolectric_test(
'PUBLIC'
],
)

5 changes: 3 additions & 2 deletions ReactAndroid/src/test/java/com/facebook/react/views/BUCK
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@ rn_robolectric_test(
name = 'views',
# Please change the contact to the oncall of your team
contacts = ['[email protected]'],
srcs = glob(['**/*.java']),
# TODO Disabled temporarily until Yoga linking is fixed t14964130
# srcs = glob(['**/*.java']),
srcs = glob(['image/*.java']),
deps = [
YOGA_TARGET,
react_native_dep('libraries/fbcore/src/test/java/com/facebook/powermock:powermock'),
Expand Down Expand Up @@ -32,4 +34,3 @@ rn_robolectric_test(
react_native_tests_target('java/com/facebook/react/bridge:testhelpers'),
],
)

1 comment on commit 709a441

@fabOnReact
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

FAILURE com.facebook.react.views.textinput.TextInputTest testPropsUpdate: Provider com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderFactoryImpl could not be instantiated: java.lang.ClassCastException: com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderFactoryImpl cannot be cast to javax.xml.parsers.DocumentBuilderFactory

today I debugged this issue this till line

react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputShadowNode.java

Lines 264 to 266 in eacc940

protected EditText createInternalEditText() {
return new EditText(getThemedContext());
}

the issue seems to be triggered from

react-native/ReactAndroid/src/test/java/com/facebook/react/views/textinput/TextInputTest.java

Lines 94 to 98 in eacc940

uiManager.createView(
textInputTag,
ReactTextInputManager.REACT_CLASS,
rootTag,
JavaOnlyMap.of(ViewProps.FONT_SIZE, 13.37, ViewProps.HEIGHT, 20.0, "placeholder", hintStr));

react-native/ReactAndroid/src/test/java/com/facebook/react/views/textinput/TextInputTest.java

Lines 163 to 173 in eacc940

public UIManagerModule getUIManagerModule() {
ReactApplicationContext reactContext = ReactTestHelper.createCatalystContextForTest();
List<ViewManager> viewManagers =
Arrays.asList(
new ViewManager[] {
new ReactTextInputManager(),
});
UIManagerModule uiManagerModule = new UIManagerModule(reactContext, viewManagers, 0);
uiManagerModule.onHostResume();
return uiManagerModule;
}

I believe I'm very far from solving this issue, but I would like to re-enable the tests. Thanks a lot for reading this and would love to receive some feedback ☮️ 🙏

Please sign in to comment.