Skip to content

Commit

Permalink
RNTester UI Redesign (#29685)
Browse files Browse the repository at this point in the history
Summary:
This Pull request adds the UI changes to the RNTester app as discussed in the MLH Fellowship.

## Changelog

This list is not exhaustive.

- The initial App screen is redesigned.
  - A bottom Navbar has been added.
   - Filter pills are added.
   - The list card UI is updated.

- The example page UI is updated.

- Recently Viewed Sections are added. It shows the last 5 recently viewed components/APIs.

- Bookmarking functionality is added.

- The documentation URL is added to the example page.

- RNTester doesn't lose its state on a hard refresh (even on iOS).

# Screenshots

<img width="373" src="https://user-images.githubusercontent.com/22813027/90530113-20346180-e192-11ea-8ef6-789fa25b402b.png" />
<img width="373" src="https://user-images.githubusercontent.com/22813027/90530112-20346180-e192-11ea-9539-706b540fcc5f.png" />
<img width="373" src="https://user-images.githubusercontent.com/22813027/90530100-1d397100-e192-11ea-8836-b88070643233.png" />
<img width="373" src="https://user-images.githubusercontent.com/22813027/90530110-1f9bcb00-e192-11ea-936b-64ee75fa4289.png" />

Pull Request resolved: #29685

Test Plan:
Imported from GitHub, without a `Test Plan:` line.

# Tested RNTester in Catalyst

{F302717939}

# Tested in RNTester in Facebook

Note: this failed **before** this diff too:

{F302745716}

Reviewed By: mdvacca, cpojer

Differential Revision: D23240434

fbshipit-source-id: 65e2766a6a097eca0e0d0fda8dadf6871e9276c2
  • Loading branch information
anku255 authored and facebook-github-bot committed Aug 26, 2020
1 parent 9b973f3 commit 549e5a8
Show file tree
Hide file tree
Showing 115 changed files with 1,854 additions and 2,405 deletions.
4 changes: 2 additions & 2 deletions packages/rn-tester/e2e/__tests__/Button-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ describe('Button', () => {
beforeAll(async () => {
await device.reloadReactNative();
await openComponentWithLabel(
'<Button>',
'<Button> Simple React Native button component.',
'Button',
'Button Simple React Native button component.',
);
});

Expand Down
4 changes: 2 additions & 2 deletions packages/rn-tester/e2e/__tests__/DatePickerIOS-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ describe('DatePickerIOS', () => {
beforeAll(async () => {
await device.reloadReactNative();
await openComponentWithLabel(
'<DatePickerIOS>',
'<DatePickerIOS> Select dates and times using the native UIDatePicker.',
'DatePickerIOS',
'DatePickerIOS Select dates and times using the native UIDatePicker.',
);
});

Expand Down
4 changes: 2 additions & 2 deletions packages/rn-tester/e2e/__tests__/Picker-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ describe('Picker', () => {
beforeAll(async () => {
await device.reloadReactNative();
await openComponentWithLabel(
'<Picker>',
'<Picker> Provides multiple options to choose from, using either a dropdown menu or a dialog.',
'Picker',
'Picker Provides multiple options to choose from, using either a dropdown menu or a dialog.',
);
});

Expand Down
2 changes: 1 addition & 1 deletion packages/rn-tester/e2e/__tests__/TextInput-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ describe('TextInput', () => {
beforeAll(async () => {
await device.reloadReactNative();
await openComponentWithLabel(
'<TextInput>',
'TextInput',
'Single and multi-line text inputs.',
);
});
Expand Down
4 changes: 2 additions & 2 deletions packages/rn-tester/e2e/__tests__/Touchable-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ describe('Touchable', () => {
beforeAll(async () => {
await device.reloadReactNative();
await openComponentWithLabel(
'<Touchable*',
'<Touchable*> and onPress Touchable and onPress examples.',
'Touchable*',
'Touchable* and onPress Touchable and onPress examples.',
);
});

Expand Down
2 changes: 1 addition & 1 deletion packages/rn-tester/e2e/test-init.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
/* global device */

const detox = require('detox');
const config = require('../../package.json').detox;
const config = require('../../../package.json').detox;
const adapter = require('detox/runners/jest/adapter');
jest.setTimeout(120000);
jasmine.getEnv().addReporter(adapter);
Expand Down
Loading

0 comments on commit 549e5a8

Please sign in to comment.