Skip to content

Commit

Permalink
Remove use of JSI_EXPORT from codegen (#37085)
Browse files Browse the repository at this point in the history 
Summary:
Pull Request resolved: #37085

changelog: [internal]

Props and event emitter does not need to use JSI_EXPORT. Therefore we can remove include of jsi.h as well.

Reviewed By: cortinico, rshest

Differential Revision: D45274824

fbshipit-source-id: b6b93958e2958d2b5c0f002792c2a62e24d4e43e
  • Loading branch information
@sammy-SC @facebook-github-bot
sammy-SC authored and facebook-github-bot committed Apr 25, 2023
1 parent 03a4de9 commit 54386f1
Show file tree
Hide file tree
Showing 6 changed files with 102 additions and 198 deletions.
54 changes: 18 additions & 36 deletions ...-native-codegen/e2e/__tests__/components/__snapshots__/GenerateEventEmitterH-test.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,11 @@ Object {
#pragma once
#include <react/renderer/components/view/ViewEventEmitter.h>
#include <jsi/jsi.h>
namespace facebook {
namespace react {
class JSI_EXPORT ArrayPropsNativeComponentViewEventEmitter : public ViewEventEmitter {
class ArrayPropsNativeComponentViewEventEmitter : public ViewEventEmitter {
public:
using ViewEventEmitter::ViewEventEmitter;
Expand All @@ -46,12 +45,11 @@ Object {
#pragma once
#include <react/renderer/components/view/ViewEventEmitter.h>
#include <jsi/jsi.h>
namespace facebook {
namespace react {
class JSI_EXPORT BooleanPropNativeComponentViewEventEmitter : public ViewEventEmitter {
class BooleanPropNativeComponentViewEventEmitter : public ViewEventEmitter {
public:
using ViewEventEmitter::ViewEventEmitter;
Expand All @@ -78,12 +76,11 @@ Object {
#pragma once
#include <react/renderer/components/view/ViewEventEmitter.h>
#include <jsi/jsi.h>
namespace facebook {
namespace react {
class JSI_EXPORT ColorPropNativeComponentViewEventEmitter : public ViewEventEmitter {
class ColorPropNativeComponentViewEventEmitter : public ViewEventEmitter {
public:
using ViewEventEmitter::ViewEventEmitter;
Expand All @@ -110,12 +107,11 @@ Object {
#pragma once
#include <react/renderer/components/view/ViewEventEmitter.h>
#include <jsi/jsi.h>
namespace facebook {
namespace react {
class JSI_EXPORT DimensionPropNativeComponentViewEventEmitter : public ViewEventEmitter {
class DimensionPropNativeComponentViewEventEmitter : public ViewEventEmitter {
public:
using ViewEventEmitter::ViewEventEmitter;
Expand All @@ -142,12 +138,11 @@ Object {
#pragma once
#include <react/renderer/components/view/ViewEventEmitter.h>
#include <jsi/jsi.h>
namespace facebook {
namespace react {
class JSI_EXPORT EdgeInsetsPropNativeComponentViewEventEmitter : public ViewEventEmitter {
class EdgeInsetsPropNativeComponentViewEventEmitter : public ViewEventEmitter {
public:
using ViewEventEmitter::ViewEventEmitter;
Expand All @@ -174,12 +169,11 @@ Object {
#pragma once
#include <react/renderer/components/view/ViewEventEmitter.h>
#include <jsi/jsi.h>
namespace facebook {
namespace react {
class JSI_EXPORT EnumPropNativeComponentViewEventEmitter : public ViewEventEmitter {
class EnumPropNativeComponentViewEventEmitter : public ViewEventEmitter {
public:
using ViewEventEmitter::ViewEventEmitter;
Expand All @@ -206,12 +200,11 @@ Object {
#pragma once
#include <react/renderer/components/view/ViewEventEmitter.h>
#include <jsi/jsi.h>
namespace facebook {
namespace react {
class JSI_EXPORT EventNestedObjectPropsNativeComponentViewEventEmitter : public ViewEventEmitter {
class EventNestedObjectPropsNativeComponentViewEventEmitter : public ViewEventEmitter {
public:
using ViewEventEmitter::ViewEventEmitter;
Expand Down Expand Up @@ -250,12 +243,11 @@ Object {
#pragma once
#include <react/renderer/components/view/ViewEventEmitter.h>
#include <jsi/jsi.h>
namespace facebook {
namespace react {
class JSI_EXPORT EventPropsNativeComponentViewEventEmitter : public ViewEventEmitter {
class EventPropsNativeComponentViewEventEmitter : public ViewEventEmitter {
public:
using ViewEventEmitter::ViewEventEmitter;
Expand Down Expand Up @@ -329,12 +321,11 @@ Object {
#pragma once
#include <react/renderer/components/view/ViewEventEmitter.h>
#include <jsi/jsi.h>
namespace facebook {
namespace react {
class JSI_EXPORT FloatPropsNativeComponentViewEventEmitter : public ViewEventEmitter {
class FloatPropsNativeComponentViewEventEmitter : public ViewEventEmitter {
public:
using ViewEventEmitter::ViewEventEmitter;
Expand All @@ -361,12 +352,11 @@ Object {
#pragma once
#include <react/renderer/components/view/ViewEventEmitter.h>
#include <jsi/jsi.h>
namespace facebook {
namespace react {
class JSI_EXPORT ImagePropNativeComponentViewEventEmitter : public ViewEventEmitter {
class ImagePropNativeComponentViewEventEmitter : public ViewEventEmitter {
public:
using ViewEventEmitter::ViewEventEmitter;
Expand All @@ -393,12 +383,11 @@ Object {
#pragma once
#include <react/renderer/components/view/ViewEventEmitter.h>
#include <jsi/jsi.h>
namespace facebook {
namespace react {
class JSI_EXPORT IntegerPropNativeComponentViewEventEmitter : public ViewEventEmitter {
class IntegerPropNativeComponentViewEventEmitter : public ViewEventEmitter {
public:
using ViewEventEmitter::ViewEventEmitter;
Expand All @@ -425,12 +414,11 @@ Object {
#pragma once
#include <react/renderer/components/view/ViewEventEmitter.h>
#include <jsi/jsi.h>
namespace facebook {
namespace react {
class JSI_EXPORT InterfaceOnlyNativeComponentViewEventEmitter : public ViewEventEmitter {
class InterfaceOnlyNativeComponentViewEventEmitter : public ViewEventEmitter {
public:
using ViewEventEmitter::ViewEventEmitter;
Expand Down Expand Up @@ -459,12 +447,11 @@ Object {
#pragma once
#include <react/renderer/components/view/ViewEventEmitter.h>
#include <jsi/jsi.h>
namespace facebook {
namespace react {
class JSI_EXPORT MixedPropNativeComponentViewEventEmitter : public ViewEventEmitter {
class MixedPropNativeComponentViewEventEmitter : public ViewEventEmitter {
public:
using ViewEventEmitter::ViewEventEmitter;
Expand All @@ -491,12 +478,11 @@ Object {
#pragma once
#include <react/renderer/components/view/ViewEventEmitter.h>
#include <jsi/jsi.h>
namespace facebook {
namespace react {
class JSI_EXPORT MultiNativePropNativeComponentViewEventEmitter : public ViewEventEmitter {
class MultiNativePropNativeComponentViewEventEmitter : public ViewEventEmitter {
public:
using ViewEventEmitter::ViewEventEmitter;
Expand All @@ -523,12 +509,11 @@ Object {
#pragma once
#include <react/renderer/components/view/ViewEventEmitter.h>
#include <jsi/jsi.h>
namespace facebook {
namespace react {
class JSI_EXPORT NoPropsNoEventsNativeComponentViewEventEmitter : public ViewEventEmitter {
class NoPropsNoEventsNativeComponentViewEventEmitter : public ViewEventEmitter {
public:
using ViewEventEmitter::ViewEventEmitter;
Expand All @@ -555,12 +540,11 @@ Object {
#pragma once
#include <react/renderer/components/view/ViewEventEmitter.h>
#include <jsi/jsi.h>
namespace facebook {
namespace react {
class JSI_EXPORT ObjectPropsNativeComponentEventEmitter : public ViewEventEmitter {
class ObjectPropsNativeComponentEventEmitter : public ViewEventEmitter {
public:
using ViewEventEmitter::ViewEventEmitter;
Expand All @@ -587,12 +571,11 @@ Object {
#pragma once
#include <react/renderer/components/view/ViewEventEmitter.h>
#include <jsi/jsi.h>
namespace facebook {
namespace react {
class JSI_EXPORT PointPropNativeComponentViewEventEmitter : public ViewEventEmitter {
class PointPropNativeComponentViewEventEmitter : public ViewEventEmitter {
public:
using ViewEventEmitter::ViewEventEmitter;
Expand All @@ -619,12 +602,11 @@ Object {
#pragma once
#include <react/renderer/components/view/ViewEventEmitter.h>
#include <jsi/jsi.h>
namespace facebook {
namespace react {
class JSI_EXPORT StringPropNativeComponentViewEventEmitter : public ViewEventEmitter {
class StringPropNativeComponentViewEventEmitter : public ViewEventEmitter {
public:
using ViewEventEmitter::ViewEventEmitter;
Expand Down
Loading

0 comments on commit 54386f1

Please sign in to comment.