Skip to content

Commit

Permalink
translation auto-update for i18n/fb4a.config.json on master
Browse files Browse the repository at this point in the history 
fbshipit-source-id: 3cedbf3b0adee97cc3c33c9c3de88ea4dcf94548
  • Loading branch information
@facebook-github-bot
Build Service authored and facebook-github-bot committed Jul 26, 2018
1 parent 4fe5acc commit 52a55fd
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 0 deletions.
3 changes: 3 additions & 0 deletions ReactAndroid/src/main/res/views/uimanager/values-as/strings.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,8 @@

<resources exclude-from-buck-resource-map="true">
<string name="link_description" gender="unknown">লিংক</string>
<string name="search_description" gender="unknown">সন্ধান ক্ষেত্ৰ</string>
<string name="image_description" gender="unknown">ছবি</string>
<string name="image_button_description" gender="unknown">বুটাম, ছবি</string>
<string name="adjustable_description" gender="unknown">মিলাব পৰা</string>
</resources>
2 changes: 2 additions & 0 deletions ReactAndroid/src/main/res/views/uimanager/values-bg/strings.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,7 @@

<resources exclude-from-buck-resource-map="true">
<string name="link_description" gender="unknown">Връзка</string>
<string name="search_description" gender="unknown">Поле за търсене</string>
<string name="image_description" gender="unknown">Изображение</string>
<string name="image_button_description" gender="unknown">Бутон, изображение</string>
</resources>
2 changes: 2 additions & 0 deletions ReactAndroid/src/main/res/views/uimanager/values-uk/strings.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,7 @@

<resources exclude-from-buck-resource-map="true">
<string name="link_description" gender="unknown">Посилання</string>
<string name="search_description" gender="unknown">Поле пошуку</string>
<string name="image_description" gender="unknown">Зображення</string>
<string name="image_button_description" gender="unknown">Кнопка, зображення</string>
</resources>

4 comments on commit 52a55fd

@vovkasm

This comment was marked as abuse.

Sign in to view

@hramos
Copy link
Contributor

@hramos hramos commented on 52a55fd Jul 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vovkasm happy to look into it, but please be mindful of your language when referring to contributions here - even when they're auto-generated.

@hramos
Copy link
Contributor

@hramos hramos commented on 52a55fd Jul 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are commits generated by an automated i18n job that runs on our internal source control. This file, and all other files touched by this job, were just added to the repo this week. The job detected the new strings.xml files and it did what it's supposed to.

We do need to look into whether we should have strings.xml files for all of these locales, however. We're looking into it.

@vovkasm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos Sorry, not mind to disrupt anyone... I'm worry that those commits where made by mistake, because they are not used in OSS (at least at first glance) and commit messages does not describe situation at all... so for open source repository these commits looks like mistakes... moreover I was worried that this is mistake in the configuration of this bot, so it can be missed by facebook devs... So it whats from my words come to...
Sorry again. And thank you for looking into it!

Please sign in to comment.