-
Notifications
You must be signed in to change notification settings - Fork 24.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix runIOS: appPath is hardcoded, read from log
Summary: The runIOS command currently assumes the path to the `xcodebuild` product - it's hardcoded ``` const appPath = `build/Build/Products/Debug-iphonesimulator/${inferredSchemeName}.app`; ``` https://github.com/facebook/react-native/blob/master/local-cli/runIOS/runIOS.js#L87 This can be a problem, when you e.g. install a release version of the app to the simulator using the cli. We use a separate schema for that, which can be selected with `--scheme`. This fix reads the output of the `xcodebuild` call and searches for the path and the name of the *.app file. If it's found, then it will be used to spawn in the simulator. If not, the default (as before) is used. Closes #8250 Differential Revision: D3469074 Pulled By: javache fbshipit-source-id: b10c7e6f48268b0c71dfcbfa661f8e5960c3aaa6
- Loading branch information
Showing
1 changed file
with
35 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters