Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bump babel-preset-react-native version to 5.0.0 for Babel 7
Reviewed By: rafeca Differential Revision: D7685340 fbshipit-source-id: f229fb5da71f2f1d277d3d55eaa0f400aa76471b
- Loading branch information
1 parent
3c0b892
commit 34bd776
34bd776There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rafeca @davidaurelio Seems like we bumped the version here but didn't actually publish on npm. This is partially breaking e2e tests in OSS. Can somebody with access publish this on npm. @hramos
34bd776There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the heads up!
@qfox Can you publish a version of
babel-preset-react-nativetomorrow?34bd776There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(We plan to bump Metro and the RN preset on Monday, sorry for the delay)
34bd776There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qfox Seems like we bumped metro but RN present is not released on npm. friendly ping :)
34bd776There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's missing from npm?
babel-preset-react-native?34bd776There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
latest on npm is 4.0 for babel-preset-react-native. we already bumped the package.json file to 5.0 but never published to npm.
So need somebody to publish babel-present-react-native v5.0 to npm.
34bd776There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes. Apologies for not leaving a note here.
Basically there was a bug with
?.and I got tied up with a necessary babel upgrade to beta.47 and wanted to prevent a double major bump for the preset. This is still the case so I want to bump the preset as soon as I got things back on track again.34bd776There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there may have been some confusion here. The preset v5 is already published, just under the
nexttag because it cut over to babel 7 and it was causing problems for people not on master.For this reason we made version 4 the
latest(the default) and we put v5 thenextrelease. This way you have to explicitly request it in order to npm/yarn add it.So, I'm going to publish a 5.0.1 with the current changes that were staged, they are not important but I'll publish them anyways. If you want to get it you need to specify v5 explicitly (so like
yarn add babel-preset-react-native@^5.0.0or something).Once the community cuts a proper pre-babel7 release and a babel7 release of RN we can drop the
nexttag and make v5 the default. This shouldn't take too long now so please be patient here.To repeat; I would recommend NOT opting in to v5 of the preset unless you run RN from master.