Skip to content

Commit

Permalink
Reduce visibility of CoreModulesPackage (#41087)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #41087

CoreModulesPackage is not being used outside of its package (neither in OSS or at Meta), I'm reducing its visibiity to package.

If you are using this class, please contact us and we will consider increasing visibiity again.

bypass-github-export-checks

changelog: [Android][Breaking] Reduce visibility of CoreModulesPackage class

Reviewed By: christophpurrer

Differential Revision: D50338546

fbshipit-source-id: 3f0ce4dd22ddfa6743760ad378e7c6e45ab58127
  • Loading branch information
mdvacca authored and facebook-github-bot committed Oct 19, 2023
1 parent fce0698 commit 30b9b01
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
TimingModule.class,
UIManagerModule.class,
})
public class CoreModulesPackage extends TurboReactPackage implements ReactPackageLogger {
class CoreModulesPackage extends TurboReactPackage implements ReactPackageLogger {

private final ReactInstanceManager mReactInstanceManager;
private final DefaultHardwareBackBtnHandler mHardwareBackBtnHandler;
Expand Down

1 comment on commit 30b9b01

@fbp93
Copy link

@fbp93 fbp93 commented on 30b9b01 Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are using this class, please contact us and we will consider increasing visibiity again.

@mdvacca Hi, we are currently using it. Our app is creating a new react context to run some syncronization operations in a different thread during the lifecycle of the app. In the meanwhile I created a custom implementation duplicating CoreModulesPackage and make it public (considering that all internal dependencies and types are public) but I wanna avoid future issues 🙏 LMK if you need more info

Please sign in to comment.