Fix RefreshControl race condition

facebook · May 1, 2016 · 2228752 · 2228752
1 parent 449a812
commit 2228752
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 9 deletions.
diff --git a/...tAndroid/src/main/java/com/facebook/react/views/swiperefresh/ReactSwipeRefreshLayout.java b/...tAndroid/src/main/java/com/facebook/react/views/swiperefresh/ReactSwipeRefreshLayout.java
@@ -20,10 +20,27 @@
  */
 public class ReactSwipeRefreshLayout extends SwipeRefreshLayout {
 
+  private boolean mRefreshing = false;
+
   public ReactSwipeRefreshLayout(ReactContext reactContext) {
     super(reactContext);
   }
 
+  @Override
+  public void setRefreshing(boolean refreshing) {
+    if (mRefreshing != refreshing) {
+      mRefreshing = refreshing;
+      // Use `post` otherwise the control won't start refreshing if refreshing is true when
+      // the component gets mounted.
+      post(new Runnable() {
+        @Override
+        public void run() {
+          ReactSwipeRefreshLayout.super.setRefreshing(mRefreshing);
+        }
+      });
+    }
+  }
+
   @Override
   public boolean onInterceptTouchEvent(MotionEvent ev) {
     if (super.onInterceptTouchEvent(ev)) {

diff --git a/...ndroid/src/main/java/com/facebook/react/views/swiperefresh/SwipeRefreshLayoutManager.java b/...ndroid/src/main/java/com/facebook/react/views/swiperefresh/SwipeRefreshLayoutManager.java
@@ -71,15 +71,8 @@ public void setSize(ReactSwipeRefreshLayout view, int size) {
   }
 
   @ReactProp(name = "refreshing")
-  public void setRefreshing(final ReactSwipeRefreshLayout view, final boolean refreshing) {
-    // Use `post` otherwise the control won't start refreshing if refreshing is true when
-    // the component gets mounted.
-    view.post(new Runnable() {
-      @Override
-      public void run() {
-        view.setRefreshing(refreshing);
-      }
-    });
+  public void setRefreshing(ReactSwipeRefreshLayout view, boolean refreshing) {
+    view.setRefreshing(refreshing);
   }
 
   @Override