Skip to content

Commit

Permalink
Making JSI_EXPORT macro definition conditional (#22561)
Browse files Browse the repository at this point in the history
Summary:
This change enables defining the macro at a more global and central location. And thereby allowing us to building this file using MSVC.
Pull Request resolved: #22561

Reviewed By: fkgozali

Differential Revision: D13529762

Pulled By: RSNara

fbshipit-source-id: c78abb26f47aba25d50305c5bc0b23b6568f1243
  • Loading branch information
mganandraj authored and facebook-github-bot committed Dec 27, 2018
1 parent 5957c8b commit 1d0404c
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions ReactCommon/jsi/jsi.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@
#include <string>
#include <vector>

#ifndef JSI_EXPORT
#define JSI_EXPORT __attribute__((visibility("default")))
#endif

class FBJSRuntime;
namespace facebook {
Expand Down

0 comments on commit 1d0404c

Please sign in to comment.