@allow-large-files flow 0.84 xplat deploy

Reviewed By: samwgoldman Differential Revision: D10851695 fbshipit-source-id: 951c628844bbbc7331d4e75f62485db88e5ba7c4
facebook · Oct 26, 2018 · 11552a7 · 11552a7
1 parent 9687090
commit 11552a7
Show file tree

Hide file tree

Showing 8 changed files with 20 additions and 9 deletions.
diff --git a/.flowconfig b/.flowconfig
@@ -101,4 +101,4 @@ untyped-import
 untyped-type-import
 
 [version]
-^0.83.0
+^0.84.0
diff --git a/.flowconfig.android b/.flowconfig.android
@@ -101,4 +101,4 @@ untyped-import
 untyped-type-import
 
 [version]
-^0.83.0
+^0.84.0
diff --git a/Libraries/Components/ScrollView/ScrollView.js b/Libraries/Components/ScrollView/ScrollView.js
@@ -397,7 +397,9 @@ export type Props = $ReadOnly<{|
    *   - `false`, deprecated, use 'never' instead
    *   - `true`, deprecated, use 'always' instead
    */
-  // $FlowFixMe(site=react_native_fb) Issues found when typing ScrollView
+  /* $FlowFixMe(>=0.84.0 site=react_native_fb) This comment suppresses an error
+   * found when Flow v0.84 was deployed. To see the error, delete this comment
+   * and run Flow. */
   keyboardShouldPersistTaps?: ?('always' | 'never' | 'handled' | false | true),
   /**
    * Called when the momentum scroll starts (scroll which occurs as the ScrollView glides to a stop).

diff --git a/Libraries/StyleSheet/processTransform.js b/Libraries/StyleSheet/processTransform.js
@@ -173,6 +173,9 @@ function _validateTransform(key, value, transformation) {
         value.length === 9 || value.length === 16,
         'Matrix transform must have a length of 9 (2d) or 16 (3d). ' +
           'Provided matrix has a length of %s: %s',
+        /* $FlowFixMe(>=0.84.0 site=react_native_fb) This comment suppresses an
+         * error found when Flow v0.84 was deployed. To see the error, delete
+         * this comment and run Flow. */
         value.length,
         stringifySafe(transformation),
       );
@@ -181,6 +184,9 @@ function _validateTransform(key, value, transformation) {
       invariant(
         value.length === 2 || value.length === 3,
         'Transform with key translate must be an array of length 2 or 3, found %s: %s',
+        /* $FlowFixMe(>=0.84.0 site=react_native_fb) This comment suppresses an
+         * error found when Flow v0.84 was deployed. To see the error, delete
+         * this comment and run Flow. */
         value.length,
         stringifySafe(transformation),
       );

diff --git a/Libraries/Utilities/HMRClient.js b/Libraries/Utilities/HMRClient.js
@@ -27,6 +27,9 @@ const HMRClient = {
     // Moving to top gives errors due to NativeModules not being initialized
     const HMRLoadingView = require('HMRLoadingView');
 
+    /* $FlowFixMe(>=0.84.0 site=react_native_fb) This comment suppresses an
+     * error found when Flow v0.84 was deployed. To see the error, delete this
+     * comment and run Flow. */
     const wsHostPort = port !== null && port !== '' ? `${host}:${port}` : host;
 
     bundleEntry = bundleEntry.replace(/\.(bundle|delta)/, '.js');

diff --git a/local-cli/templates/HelloWorld/_flowconfig b/local-cli/templates/HelloWorld/_flowconfig
@@ -67,4 +67,4 @@ suppress_comment=\\(.\\|\n\\)*\\$FlowFixedInNextDeploy
 suppress_comment=\\(.\\|\n\\)*\\$FlowExpectedError
 
 [version]
-^0.83.0
+^0.84.0
diff --git a/package.json b/package.json
@@ -217,7 +217,7 @@
     "eslint-plugin-prettier": "2.6.0",
     "eslint-plugin-react": "7.8.2",
     "eslint-plugin-react-native": "3.5.0",
-    "flow-bin": "^0.83.0",
+    "flow-bin": "^0.84.0",
     "jest": "23.4.1",
     "jest-junit": "5.1.0",
     "prettier": "1.13.6",

diff --git a/yarn.lock b/yarn.lock
@@ -2827,10 +2827,10 @@ flat-cache@^1.2.1:
     graceful-fs "^4.1.2"
     write "^0.2.1"
 
-flow-bin@^0.83.0:
-  version "0.83.0"
-  resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.83.0.tgz#fd26f5f95758d7701264b3f9a1e1a3d4cbcab1a9"
-  integrity sha512-1K83EL/U9Gh0BaXPKkZe6TRizSmNSKx9Wuws1c8gh7DJEwiburtCxYT+4o7in1+GnNEm3CZWnbnVV8n9HMpiDA==
+flow-bin@^0.84.0:
+  version "0.84.0"
+  resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.84.0.tgz#4cb2364c750fb37a7840524fa62456b53f64cdcb"
+  integrity sha512-ocji8eEYp+YfICsm+F6cIHUcD7v5sb0/ADEXm6gyUKdjQzmSckMrPUdZtyfP973t3YGHKliUMxMvIBHyR5LbXQ==
 
 for-in@^1.0.1, for-in@^1.0.2:
   version "1.0.2"
-Original file line number
+Diff line change
@@ Expand Up / @@ -101,4 +101,4 @@ untyped-import @@
     untyped-type-import
     [version]
-    ^0.83.0
+    ^0.84.0