-
Notifications
You must be signed in to change notification settings - Fork 24.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add basic shims for Android plugin 2.3.3
- Loading branch information
1 parent
7182170
commit 0d43751
Showing
1 changed file
with
13 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0d43751
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I modified my react.gradle with this code and still can't build APK, i got duplicate file error
(all images inside this folder)
android/app/src/main/res/drawable-mdpi/
and(all images inside this folder)
/android/app/build/generated/res/react/release/drawable-mdpi/
somebody please help me.
0d43751
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so, after uninstalling Code push i was able to build the APK.
Thank you.
0d43751
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sashaba that makes sense, I have local modifications to Code Push to make it work for me too. Assuming this gets traction I'll submit a PR to that project as well. Thanks for testing!
0d43751
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CFKevinRef that PR would be great, hope you make it. If you don’t mind, may I ask you which file of code push did you modify?
Thanks.
0d43751
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I would think that this merged PR should take care of things: microsoft/react-native-code-push#1219
What version of CodePush and the Android Gradle Plugin are you using?
0d43751
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code push 5.4.0 and gradle 3.1.3, i'm going to try #1219.
Thank you.