Skip to content

Commit

Permalink
fixed SDK issue while uploading app in debug scheme (#33153)
Browse files Browse the repository at this point in the history
Summary:
Problem - Error when trying to publish to Apple Store in debug scheme

Error thread - #31507

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://github.com/facebook/react-native/wiki/Changelog
-->

[General][Removed] - The diffs renames the required variable which was causing conflicts in names with Apple core SDK's

Pull Request resolved: #33153

Reviewed By: lunaleaps

Differential Revision: D34392529

Pulled By: sshic

fbshipit-source-id: 78387999f94e0db71f5d3dafff51e58d7d0c1847
  • Loading branch information
arinjay authored and facebook-github-bot committed Jun 6, 2022
1 parent f1c614b commit 086c13d
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 11 deletions.
18 changes: 9 additions & 9 deletions React/Base/RCTKeyCommands.m
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@

@interface UIEvent (UIPhysicalKeyboardEvent)

@property (nonatomic) NSString *_modifiedInput;
@property (nonatomic) NSString *_modifiedEventInput;
@property (nonatomic) NSString *_unmodifiedInput;
@property (nonatomic) UIKeyModifierFlags _modifierFlags;
@property (nonatomic) BOOL _isKeyDown;
@property (nonatomic) UIKeyModifierFlags _modifierEventFlags;
@property (nonatomic) BOOL _isKeyEventDown;
@property (nonatomic) long _keyCode;

@end
Expand Down Expand Up @@ -116,16 +116,16 @@ - (void)handleKeyUIEventSwizzle:(UIEvent *)event
UIKeyModifierFlags modifierFlags = 0;
BOOL isKeyDown = NO;

if ([event respondsToSelector:@selector(_modifiedInput)]) {
modifiedInput = [event _modifiedInput];
if ([event respondsToSelector:@selector(_modifiedEventInput)]) {
modifiedInput = [event _modifiedEventInput];
}

if ([event respondsToSelector:@selector(_modifierFlags)]) {
modifierFlags = [event _modifierFlags];
if ([event respondsToSelector:@selector(_modifierEventFlags)]) {
modifierFlags = [event _modifierEventFlags];
}

if ([event respondsToSelector:@selector(_isKeyDown)]) {
isKeyDown = [event _isKeyDown];
if ([event respondsToSelector:@selector(_isKeyEventDown)]) {
isKeyDown = [event _isKeyEventDown];
}

BOOL interactionEnabled = !UIApplication.sharedApplication.isIgnoringInteractionEvents;
Expand Down
2 changes: 1 addition & 1 deletion React/DevSupport/RCTPackagerClient.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ extern const int RCT_PACKAGER_CLIENT_PROTOCOL_VERSION;
@protocol RCTPackagerClientMethod <NSObject>

- (void)handleRequest:(NSDictionary<NSString *, id> *)params withResponder:(RCTPackagerClientResponder *)responder;
- (void)handleNotification:(NSDictionary<NSString *, id> *)params;
- (void)handlePackageNotification:(NSDictionary<NSString *, id> *)params;

@optional

Expand Down
2 changes: 1 addition & 1 deletion React/DevSupport/RCTPackagerConnection.mm
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ - (void)addHandler:(id<RCTPackagerClientMethod>)handler forMethod:(NSString *)me

[self
addNotificationHandler:^(NSDictionary<NSString *, id> *notification) {
[handler handleNotification:notification];
[handler handlePackageNotification:notification];
}
queue:queue
forMethod:method];
Expand Down

0 comments on commit 086c13d

Please sign in to comment.