-
Notifications
You must be signed in to change notification settings - Fork 24.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: The iOS snapshots have been out of date for months, but the failure was not caught in open source's `test_objc` job because `xcpretty` was swallowing the non-zero error code. To fix this, I enabled recording mode in RNTesterSnapshotTests.m temporarily, and re-ran the tests in order to update the snapshots. I've also switched the test device used by Circle CI to iPhone 6s to be consistent with the snapshot tests that run internally at Facebook. Integration tests are not fully fixed yet, but I can confirm the following tests are fixed by this diff: ``` -[RNTesterIntegrationTests testImageSnapshotTest] -[RNTesterIntegrationTests testSimpleSnapshotTest] -[RNTesterSnapshotTests testARTExample] -[RNTesterSnapshotTests testLayoutExample] -[RNTesterSnapshotTests testSliderExample] -[RNTesterSnapshotTests testSwitchExample] -[RNTesterSnapshotTests testTabBarExample] -[RNTesterSnapshotTests testTextExample] -[RNTesterSnapshotTests testViewExample] ``` I've also fixed a few shellcheck warnings in related scripts. Reviewed By: fkgozali Differential Revision: D13506865 fbshipit-source-id: dab985130c2ff3cb9dea19d1f87c8ee65d8c141e
- Loading branch information
1 parent
bb09866
commit 0407d8c
Showing
22 changed files
with
8 additions
and
4 deletions.
There are no files selected for viewing
Binary file modified
BIN
+37.6 KB
(350%)
...renceImages/IntegrationTests-IntegrationTestsApp/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+60 Bytes
(100%)
...Tests/ReferenceImages/RNTester-js-RNTesterApp.ios/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+149 KB
...Tests/ReferenceImages/RNTester-js-RNTesterApp.ios/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+655 Bytes
(100%)
...ts/ReferenceImages/RNTester-js-RNTesterApp.ios/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+137 KB
(190%)
...eferenceImages/RNTester-js-RNTesterApp.ios/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.29 KB
(100%)
...ts/ReferenceImages/RNTester-js-RNTesterApp.ios/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.97 KB
(99%)
...ts/ReferenceImages/RNTester-js-RNTesterApp.ios/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.71 KB
(100%)
...ts/ReferenceImages/RNTester-js-RNTesterApp.ios/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-43.4 KB
(88%)
...ests/ReferenceImages/RNTester-js-RNTesterApp.ios/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-211 Bytes
(100%)
...ests/ReferenceImages/RNTester-js-RNTesterApp.ios/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters