Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_#23336 #792

Merged
merged 2 commits into from
Feb 15, 2019
Merged

fix_#23336 #792

merged 2 commits into from
Feb 15, 2019

Conversation

RoJoHub
Copy link
Contributor

@RoJoHub RoJoHub commented Feb 15, 2019

Issues: Related to #13439
PR: Related to #23336

fix android code,and also docs need to change

@cpojer

@react-native-bot
Copy link

react-native-bot commented Feb 15, 2019

Deploy preview for react-native ready!

Built with commit b86dc04

https://deploy-preview-792--react-native.netlify.com

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cpojer cpojer merged commit 093c74a into facebook:master Feb 15, 2019
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Jun 12, 2019
Summary:
Issues: Related to  #13439
react-native-website:Related to PR [#792](facebook/react-native-website#792)
solution: #13439 (comment)

When we integration with Existing  Android Apps.and set LifecycleState  is `LifecycleState.RESUMED`.
It's lead to `mCurrentActivity`  is null .

At this time , the behave of set `mCurrentActivity ` which  is unexpectedly.

## Changelog
[Android] [Fixed] - Check if mCurrentActivity is set according to LifecycleState
Pull Request resolved: #23336

Differential Revision: D14298654

Pulled By: cpojer

fbshipit-source-id: 5cc17539a51154faeb838349b068d92511946f79
kelset pushed a commit to facebook/react-native that referenced this pull request Jul 3, 2019
Summary:
Issues: Related to  #13439
react-native-website:Related to PR [#792](facebook/react-native-website#792)
solution: #13439 (comment)

When we integration with Existing  Android Apps.and set LifecycleState  is `LifecycleState.RESUMED`.
It's lead to `mCurrentActivity`  is null .

At this time , the behave of set `mCurrentActivity ` which  is unexpectedly.

## Changelog
[Android] [Fixed] - Check if mCurrentActivity is set according to LifecycleState
Pull Request resolved: #23336

Differential Revision: D14298654

Pulled By: cpojer

fbshipit-source-id: 5cc17539a51154faeb838349b068d92511946f79
M-i-k-e-l pushed a commit to M-i-k-e-l/react-native that referenced this pull request Mar 10, 2020
…k#23336)

Summary:
Issues: Related to  facebook#13439
react-native-website:Related to PR [facebook#792](facebook/react-native-website#792)
solution: facebook#13439 (comment)

When we integration with Existing  Android Apps.and set LifecycleState  is `LifecycleState.RESUMED`.
It's lead to `mCurrentActivity`  is null .

At this time , the behave of set `mCurrentActivity ` which  is unexpectedly.

## Changelog
[Android] [Fixed] - Check if mCurrentActivity is set according to LifecycleState
Pull Request resolved: facebook#23336

Differential Revision: D14298654

Pulled By: cpojer

fbshipit-source-id: 5cc17539a51154faeb838349b068d92511946f79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants