Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android typo #4280

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Android typo #4280

merged 1 commit into from
Oct 16, 2024

Conversation

callaars
Copy link
Contributor

There was a typo in the manual on enabling the new architecture for Android.

There was a typo in the manual on enabling the new architecture for Android.
@facebook-github-bot
Copy link

Hi @callaars!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 58bf85c
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/670e83a208f97e000980edf0
😎 Deploy Preview https://deploy-preview-4280--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the typo!

@cipolleschi
Copy link
Contributor

@callaars could you sign the CLA? Otherwise I can't merge the PR

@callaars
Copy link
Contributor Author

@cipolleschi done, thanks.

@cortinico
Copy link
Contributor

Can you accept our CLA @callaars otherwise we cannot merge this PR?

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@cortinico cortinico merged commit 074dec6 into facebook:main Oct 16, 2024
4 checks passed
@callaars callaars deleted the patch-1 branch October 16, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants