Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] TalkBack support for ScrollView accessibility announcements (list and grid) #3205

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

fabOnReact
Copy link
Contributor

@fabOnReact fabOnReact commented Jul 11, 2022

Adding documentation for PR facebook/react-native#33180
Not ready to merge as facebook/react-native#33180 was reverted

@netlify
Copy link

netlify bot commented Jul 11, 2022

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 404e392
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/62cba4453520d30008c8b9b5
😎 Deploy Preview https://deploy-preview-3205--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Simek Simek added 🕐 Waiting on PR These may be waiting for a PR to the facebook/react-native to be merged Wait on future Release This indicates a PR that updates the doc to match a future release. labels Jul 15, 2022
@fabOnReact fabOnReact marked this pull request as ready for review July 21, 2022 15:29
@fabOnReact fabOnReact marked this pull request as draft July 21, 2022 15:29
@fabOnReact fabOnReact changed the title TalkBack support for ScrollView accessibility announcements (list and grid) [Documentation] TalkBack support for ScrollView accessibility announcements (list and grid) Jul 22, 2022
@Simek Simek removed the 🕐 Waiting on PR These may be waiting for a PR to the facebook/react-native to be merged label Jul 22, 2022
@Simek
Copy link
Collaborator

Simek commented Jul 22, 2022

@fabriziobertoglio1987 It looks like related PR has been merge and become a part of 0.70 RC, so it would be nice to ship this before new version docs cut.

Is there something what you would like to finish, or is this PR ready for review?

Edit: Oh, it has been reverted, just spotted that...

@fabOnReact
Copy link
Contributor Author

fabOnReact commented Aug 16, 2022

Related facebook/react-native@3f8071d

D37668064 (facebook/react-native@463af23) caused issues in VR Store where on tail load, the scroll position would reset and go back to the top.

@fabOnReact fabOnReact marked this pull request as ready for review September 28, 2022 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Wait on future Release This indicates a PR that updates the doc to match a future release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants