Replace authorImage with authorImageURL #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amyrlam we have to wait till the latest version of Docusaurus is released
before updating the code here or else the site will be broken because the
Docusaurus version here doesn't expect authorImageURL. This PR should also
include the Docusaurus version bump.
…On Wed, Apr 18, 2018, 12:10 AM Amy Lam ***@***.***> wrote:
authorImage will be deprecated in Docusaurus
Relates to: facebook/docusaurus#577
<facebook/docusaurus#577> cc @yangshun
<https://github.com/yangshun>
------------------------------
You can view, comment on, or merge this pull request online at:
#314
Commit Summary
- Replace authorImage with authorImageURL
File Changes
- *M*
website/blog/2015-03-26-react-native-bringing-modern-web-techniques-to-mobile.md
<https://github.com/facebook/react-native-website/pull/314/files#diff-0>
(2)
- *M* website/blog/2015-09-14-react-native-for-android.md
<https://github.com/facebook/react-native-website/pull/314/files#diff-1>
(2)
- *M* website/blog/2015-11-23-making-react-native-apps-accessible.md
<https://github.com/facebook/react-native-website/pull/314/files#diff-2>
(2)
- *M* website/blog/2016-03-24-introducing-hot-reloading.md
<https://github.com/facebook/react-native-website/pull/314/files#diff-3>
(2)
- *M* website/blog/2016-03-28-dive-into-react-native-performance.md
<https://github.com/facebook/react-native-website/pull/314/files#diff-4>
(2)
- *M* website/blog/2016-04-13-react-native-a-year-in-review.md
<https://github.com/facebook/react-native-website/pull/314/files#diff-5>
(2)
- *M* website/blog/2016-07-06-toward-better-documentation.md
<https://github.com/facebook/react-native-website/pull/314/files#diff-6>
(2)
- *M* website/blog/2016-08-12-react-native-meetup-san-francisco.md
<https://github.com/facebook/react-native-website/pull/314/files#diff-7>
(2)
- *M*
website/blog/2016-08-19-right-to-left-support-for-react-native-apps.md
<https://github.com/facebook/react-native-website/pull/314/files#diff-8>
(2)
- *M* website/blog/2016-09-08-exponent-talks-unraveling-navigation.md
<https://github.com/facebook/react-native-website/pull/314/files#diff-9>
(2)
- *M*
website/blog/2016-10-25-0.36-headless-js-the-keyboard-api-and-more.md
<https://github.com/facebook/react-native-website/pull/314/files#diff-10>
(2)
- *M*
website/blog/2016-11-08-introducing-button-yarn-and-a-public-roadmap.md
<https://github.com/facebook/react-native-website/pull/314/files#diff-11>
(2)
- *M* website/blog/2016-12-05-easier-upgrades.md
<https://github.com/facebook/react-native-website/pull/314/files#diff-12>
(2)
- *M* website/blog/2017-01-07-monthly-release-cadence.md
<https://github.com/facebook/react-native-website/pull/314/files#diff-13>
(2)
- *M* website/blog/2017-02-14-using-native-driver-for-animated.md
<https://github.com/facebook/react-native-website/pull/314/files#diff-14>
(2)
- *M* website/blog/2017-03-13-better-list-views.md
<https://github.com/facebook/react-native-website/pull/314/files#diff-15>
(2)
- *M* website/blog/2017-03-13-idx-the-existential-function.md
<https://github.com/facebook/react-native-website/pull/314/files#diff-16>
(2)
- *M* website/blog/2017-03-13-introducing-create-react-native-app.md
<https://github.com/facebook/react-native-website/pull/314/files#diff-17>
(2)
- *M* website/blog/2017-06-21-react-native-monthly-1.md
<https://github.com/facebook/react-native-website/pull/314/files#diff-18>
(2)
- *M* website/blog/2017-07-28-react-native-monthly-2.md
<https://github.com/facebook/react-native-website/pull/314/files#diff-19>
(2)
- *M*
website/blog/2017-08-07-react-native-performance-in-marketplace.md
<https://github.com/facebook/react-native-website/pull/314/files#diff-20>
(2)
- *M* website/blog/2017-08-30-react-native-monthly-3.md
<https://github.com/facebook/react-native-website/pull/314/files#diff-21>
(2)
- *M* website/blog/2017-09-21-react-native-monthly-4.md
<https://github.com/facebook/react-native-website/pull/314/files#diff-22>
(2)
- *M* website/blog/2017-11-06-react-native-monthly-5.md
<https://github.com/facebook/react-native-website/pull/314/files#diff-23>
(2)
- *M* website/blog/2018-01-09-react-native-monthly-6.md
<https://github.com/facebook/react-native-website/pull/314/files#diff-24>
(2)
- *M*
website/blog/2018-01-18-implementing-twitters-app-loading-animation-in-react-native.md
<https://github.com/facebook/react-native-website/pull/314/files#diff-25>
(2)
- *M* website/blog/2018-03-05-AWS-app-sync.md
<https://github.com/facebook/react-native-website/pull/314/files#diff-26>
(2)
- *M*
website/blog/2018-03-22-building-input-accessory-view-for-react-native.md
<https://github.com/facebook/react-native-website/pull/314/files#diff-27>
(2)
- *M* website/blog/2018-04-09-build-com-app.md
<https://github.com/facebook/react-native-website/pull/314/files#diff-28>
(2)
Patch Links:
- https://github.com/facebook/react-native-website/pull/314.patch
- https://github.com/facebook/react-native-website/pull/314.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#314>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/ABQRHTw4ox4sIpoAHULBt7_LULFNz1Ebks5tpubkgaJpZM4TZiFO>
.
|
|
Oops, something went wrong with this deploy preview. @charpeni can you look at this? |
amyrlam
changed the title
|
Ah gotcha, sorry about that. I added |
|
@amyrlam Docusaurus 1.0.12 has been released! |
amyrlam
force-pushed
the
amy/update-docusaurus
branch
from
dc1201f to
ed09b1f
Compare
|
Deploy preview for react-native ready! Built with commit 963a62e https://deploy-preview-314--react-native.netlify.com Changes to Thank you for your contributions. |
amyrlam
force-pushed
the
amy/update-docusaurus
branch
from
d6429eb to
5fe5002
Compare
amyrlam
changed the title
|
👋 Sorry for the confusion before, this is ready for review now. |
|
Updated Docusaurus to latest 1.0.14 |
JoelMarcey
approved these changes
Apr 25, 2018
There was a problem hiding this comment.
This looks good. I am going to let @hramos approve and merge it in.
authorImage will be deprecated in a future Docusaurus version
amyrlam
force-pushed
the
amy/update-docusaurus
branch
from
572ed65 to
86a7a61
Compare
amyrlam
force-pushed
the
amy/update-docusaurus
branch
from
86a7a61 to
963a62e
Compare
|
Thanks for your contribution! |
amyrlam
added a commit
to amyrlam/Docusaurus
that referenced
this pull request
May 8, 2018
authorImage was replaced by authorImageURL in facebook#577 authorImage was removed in react-native-website in facebook/react-native-website#314
amyrlam
added a commit
to amyrlam/Docusaurus
that referenced
this pull request
May 8, 2018
authorImage was replaced by authorImageURL in facebook#577 authorImage was removed from react-native-website in facebook/react-native-website#314 authorImage was undocumented, so no docs changes
amyrlam
added a commit
to amyrlam/Docusaurus
that referenced
this pull request
May 8, 2018
authorImage was replaced by authorImageURL in facebook#577 authorImage was removed from react-native-website in facebook/react-native-website#314 authorImage was undocumented, so no docs changes
yangshun
pushed a commit
to facebook/docusaurus
that referenced
this pull request
May 8, 2018
authorImage was replaced by authorImageURL in #577 authorImage was removed from react-native-website in facebook/react-native-website#314 authorImage was undocumented, so no docs changes
amyrlam
added a commit
to amyrlam/react-native-website
that referenced
this pull request
May 10, 2018
Follow on to: facebook#314
amyrlam
added a commit
to amyrlam/react-native-website
that referenced
this pull request
May 10, 2018
charpeni
pushed a commit
that referenced
this pull request
May 11, 2018
risenforward
pushed a commit
to risenforward/proactive-web
that referenced
this pull request
Jan 4, 2019
JackWillie
added a commit
to JackWillie/react-native-website
that referenced
this pull request
Nov 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⬆️ Docusaurus
authorImagewill be deprecated in DocusaurusIncluded format updates generated by Docusaurus, re: format updates, check out https://github.com/facebook/react-native-website/pull/314/files?w=1will address separatelyRelates to: facebook/docusaurus#577 cc @yangshun
No visual change to author image in blog:
