Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getting-started.md #2153

Closed
wants to merge 1 commit into from
Closed

Update getting-started.md #2153

wants to merge 1 commit into from

Conversation

MoKhajavi75
Copy link
Contributor

As node-gyp supports Python 3, we can remove version 2 from docs.

cc @cpojer

@react-native-bot
Copy link

Deploy preview for react-native ready!

Built with commit 091f7c5

https://deploy-preview-2153--react-native.netlify.app

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

@Simek
Copy link
Collaborator

Simek commented Aug 18, 2020

Refs #2070

Hi @MohamadKh75, since this guide has been updated lately please checkout the review comments and discussion about Python version in the PR linked above. If you sure that there are no other libraries or core parts that depends on Python 2, please test the clean setup on both macOS and Windows and provide the proof that it worked. We must be sure that this bump will not introduce any regression or problem for the users.

@MoKhajavi75
Copy link
Contributor Author

Hi @Simek

I just can confirm about android.

I asked @cpojer about this but it seems in your ref that it will cause problems for Windows users.

Maybe it should be good to separate sections for mobile and desktop 🤔

@sunnylqm
Copy link
Contributor

sunnylqm commented Oct 6, 2020

I think python is now totally unnecessary for windows platform. Just tested on a brand new windows 10 machine with only node installed, initiating is all good.

@Simek
Copy link
Collaborator

Simek commented Oct 7, 2020

Closing in favor of #2250, thank you for the research. 🙂

@Simek Simek closed this Oct 7, 2020
@MoKhajavi75 MoKhajavi75 deleted the patch-3 branch October 7, 2020 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants