Skip to content

Commit

Permalink
rename ServerHealthCheckerCallback::ExtraHeaders to ServerHealthCheck…
Browse files Browse the repository at this point in the history
…erCallback::ExtraInfo

Summary: We will use extraInfo to pass the shiv server id info from ServerHealthChecker to ServerHandler which is not from the response headers anymore. So renaming the argument.

Differential Revision: D47881835

fbshipit-source-id: 8c2756619052c775d62d489368ee18109972c5bb
  • Loading branch information
Fei Chen authored and facebook-github-bot committed Aug 3, 2023
1 parent 8c956b4 commit 6eb64cc
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions proxygen/lib/healthcheck/ServerHealthCheckerCallback.h
Original file line number Diff line number Diff line change
Expand Up @@ -59,19 +59,19 @@ const std::string serverDownInfoStr(ServerDownInfo info);
class ServerHealthCheckerCallback {
public:
// Additional info received from a successful healthcheck (e.g. HTTP headers)
using ExtraHeaders = std::vector<std::pair<std::string, std::string>>;
using ExtraInfo = std::vector<std::pair<std::string, std::string>>;

virtual void processHealthCheckFailure(
const TimePoint& startTime,
ServerDownInfo reason,
const std::string& extraReasonStr = std::string(),
const ExtraHeaders* extraHeaders = nullptr) = 0;
const ExtraInfo* extraInfo = nullptr) = 0;

virtual void processHealthCheckSuccess(
const TimePoint& startTime,
LoadType load,
const ServerLoadInfo* serverLoadInfo = nullptr,
const ExtraHeaders* extraHeaders = nullptr) = 0;
const ExtraInfo* extraInfo = nullptr) = 0;

virtual ~ServerHealthCheckerCallback() {
}
Expand Down

0 comments on commit 6eb64cc

Please sign in to comment.