Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit the submodule #67

Closed
wants to merge 1 commit into from
Closed

Commit the submodule #67

wants to merge 1 commit into from

Conversation

bigfootjon
Copy link
Member

This is part 1 of a 3 part series of diffs:

  1. Update the submodule to be checked in instead of providing instructions in a doc
  2. Update the buck2 binary to use OSS dotslash
  3. Remove the prelude submodule completely (depends on some other changes to buck2 that haven't released yet)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 22, 2024
@facebook-github-bot
Copy link
Contributor

@bigfootjon has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@bigfootjon merged this pull request in 005b653.

@bigfootjon bigfootjon deleted the builtin-submodule branch February 23, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bigfootjon @facebook-github-bot