Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buck2 init --git #60

Closed
wants to merge 1 commit into from
Closed

buck2 init --git #60

wants to merge 1 commit into from

Conversation

shayne-fletcher
Copy link
Contributor

Differential Revision: D53099111

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 25, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53099111

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53099111

shayne-fletcher pushed a commit that referenced this pull request Jan 25, 2024
Summary: Pull Request resolved: #60

Differential Revision: D53099111

fbshipit-source-id: a57cb5e3d10363361cabff566f32fc58c00974b9
shayne-fletcher pushed a commit that referenced this pull request Jan 25, 2024
Summary:


since where we are trying to put the prelude directory is already the root of a git repo, `buck2  init --git` is inappropriate. instead use git to get a copy.

Differential Revision:
D53099111

Privacy Context Container: L1124100
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53099111

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53099111

shayne-fletcher pushed a commit that referenced this pull request Jan 25, 2024
Summary:
Pull Request resolved: #60

since where we are trying to put the prelude directory is already the root of a git repo, `buck2  init --git` is inappropriate. instead ~~use git to get a copy as a submodule~~ delegate to `dtolnay/install-buck2@latest` to pull in  the prelude submodule (at a coherent version with the buck2 installed)

Differential Revision:
D53099111

Privacy Context Container: L1124100

fbshipit-source-id: 5006eb8c81327ba381f2c22082495f9be3c82324
facebook-github-bot pushed a commit that referenced this pull request Jan 25, 2024
Summary:


since where we are trying to put the prelude directory is already the root of a git repo, `buck2  init --git` is inappropriate. instead ~~use git to get a copy as a submodule~~ delegate to `dtolnay/install-buck2@latest` to pull in  the prelude submodule (at a coherent version with the buck2 installed)

Differential Revision:
D53099111

Privacy Context Container: L1124100
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53099111

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53099111

shayne-fletcher pushed a commit that referenced this pull request Jan 25, 2024
Summary:
Pull Request resolved: #60

since where we are trying to put the prelude directory is already the root of a git repo, `buck2  init --git` is inappropriate. instead ~~use git to get a copy as a submodule~~ delegate to `dtolnay/install-buck2@latest` to pull in  the prelude submodule (at a coherent version with the buck2 installed)

Differential Revision:
D53099111

Privacy Context Container: L1124100

fbshipit-source-id: 383f0ff16741f6bf35f9bc7e8225f85f91095e60
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53099111

shayne-fletcher pushed a commit that referenced this pull request Jan 25, 2024
Summary:
Pull Request resolved: #60

since where we are trying to put the prelude directory is already the root of a git repo, `buck2  init --git` is inappropriate. instead ~~use git to get a copy as a submodule~~ delegate to `dtolnay/install-buck2@latest` to pull in  the prelude submodule (at a coherent version with the buck2 installed)

Differential Revision:
D53099111

Privacy Context Container: L1124100

fbshipit-source-id: d5965a9e9c31c91f3b831325c713db61a730b698
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53099111

shayne-fletcher pushed a commit that referenced this pull request Jan 26, 2024
Summary:
Pull Request resolved: #60

since where we are trying to put the prelude directory is already the root of a git repo, `buck2  init --git` is inappropriate. instead ~~use git to get a copy as a submodule~~ delegate to `dtolnay/install-buck2@latest` to pull in  the prelude submodule (at a coherent version with the buck2 installed)

Differential Revision:
D53099111

Privacy Context Container: L1124100

fbshipit-source-id: 7799ed9b329659862b843e8d933d7b952579a370
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53099111

shayne-fletcher pushed a commit that referenced this pull request Jan 26, 2024
Summary:
Pull Request resolved: #60

since where we are trying to put the prelude directory is already the root of a git repo, `buck2  init --git` is inappropriate. instead ~~use git to get a copy as a submodule~~ delegate to `dtolnay/install-buck2@latest` to pull in  the prelude submodule (at a coherent version with the buck2 installed)

Differential Revision:
D53099111

Privacy Context Container: L1124100

fbshipit-source-id: bef539c2867f60d86e8e76a377ae1cea78e7963e
Summary:


since where we are trying to put the prelude directory is already the root of a git repo, `buck2  init --git` is inappropriate. instead ~~use git to get a copy as a submodule~~ delegate to `dtolnay/install-buck2@latest` to pull in  the prelude submodule (at a coherent version with the buck2 installed)

Differential Revision:
D53099111

Privacy Context Container: L1124100
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53099111

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 4f6131b.

@shayne-fletcher shayne-fletcher deleted the export-D53099111 branch January 26, 2024 19:17
shayne-fletcher pushed a commit to shayne-fletcher/ocamlrep that referenced this pull request Jan 27, 2024
Summary:
Pull Request resolved: facebook#60

since where we are trying to put the prelude directory is already the root of a git repo, `buck2  init --git` is inappropriate. instead ~~use git to get a copy as a submodule~~ delegate to `dtolnay/install-buck2@latest` to pull in  the prelude submodule (at a coherent version with the buck2 installed)

Reviewed By: dtolnay

Differential Revision:
D53099111

Privacy Context Container: L1124100

fbshipit-source-id: a1cc06fc9a4986acf31fc220d44227c3dbb5d5ab
shayne-fletcher pushed a commit to shayne-fletcher/ocamlrep that referenced this pull request Jan 27, 2024
Summary:
Pull Request resolved: facebook#60

since where we are trying to put the prelude directory is already the root of a git repo, `buck2  init --git` is inappropriate. instead ~~use git to get a copy as a submodule~~ delegate to `dtolnay/install-buck2@latest` to pull in  the prelude submodule (at a coherent version with the buck2 installed)

Reviewed By: dtolnay

Differential Revision:
D53099111

Privacy Context Container: L1124100

fbshipit-source-id: a1cc06fc9a4986acf31fc220d44227c3dbb5d5ab
shayne-fletcher pushed a commit to shayne-fletcher/ocamlrep that referenced this pull request Jan 27, 2024
Summary:
Pull Request resolved: facebook#60

since where we are trying to put the prelude directory is already the root of a git repo, `buck2  init --git` is inappropriate. instead ~~use git to get a copy as a submodule~~ delegate to `dtolnay/install-buck2@latest` to pull in  the prelude submodule (at a coherent version with the buck2 installed)

Reviewed By: dtolnay

Differential Revision:
D53099111

Privacy Context Container: L1124100

fbshipit-source-id: a1cc06fc9a4986acf31fc220d44227c3dbb5d5ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants