Add include dirs to the CGO command line arguments #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D44788778 |
jvshahid
added a commit
to jvshahid/buck2-prelude
that referenced
this pull request
Apr 10, 2023
Summary: X-link: facebook/ocamlrep#23 Without the include dirs, the cgo command won't be able to find the header files causing `buck2 build` to fail. Differential Revision: D44788778 fbshipit-source-id: 8222f75c872ffd8166111373fcc34893c19e20e9
jvshahid
added a commit
to jvshahid/buck2
that referenced
this pull request
Apr 10, 2023
Summary: X-link: facebook/ocamlrep#23 Without the include dirs, the cgo command won't be able to find the header files causing `buck2 build` to fail. Differential Revision: D44788778 fbshipit-source-id: f89c251fbed02ec377e3c63ee47baf597504d733
Summary: X-link: facebook/buck2#134 X-link: facebook/buck2-prelude#8 Pull Request resolved: facebook#23 Without the include dirs, the cgo command won't be able to find the header files causing `buck2 build` to fail. Differential Revision: D44788778 fbshipit-source-id: 973def0e23995be04f7ba05fc02e73365d15627d
jvshahid
added a commit
to jvshahid/buck2
that referenced
this pull request
Apr 10, 2023
Summary: Pull Request resolved: facebook#134 X-link: facebook/buck2-prelude#8 X-link: facebook/ocamlrep#23 Without the include dirs, the cgo command won't be able to find the header files causing `buck2 build` to fail. Differential Revision: D44788778 fbshipit-source-id: 56f4f804f58437008339c9bea63cacff1800d0d9
jvshahid
force-pushed
the
export-D44788778
branch
from
e3eb926 to
fd157b8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44788778 |
jvshahid
added a commit
to jvshahid/buck2-prelude
that referenced
this pull request
Apr 10, 2023
Summary: X-link: facebook/buck2#134 Pull Request resolved: facebook#8 X-link: facebook/ocamlrep#23 Without the include dirs, the cgo command won't be able to find the header files causing `buck2 build` to fail. Differential Revision: D44788778 fbshipit-source-id: a18b2994bd6289716932e45ff9ce9f95ba45720c
facebook-github-bot
pushed a commit
to facebook/buck2-prelude
that referenced
this pull request
Apr 13, 2023
Summary: X-link: facebook/buck2#134 Pull Request resolved: #8 X-link: facebook/ocamlrep#23 Without the include dirs, the cgo command won't be able to find the header files causing `buck2 build` to fail. Reviewed By: krallin Differential Revision: D44788778 fbshipit-source-id: d1ed1a8ec2463aaba615844c0a3ff54158c1dc69
|
This pull request has been merged in e9320e2. |
facebook-github-bot
pushed a commit
to facebook/buck2
that referenced
this pull request
Apr 13, 2023
Summary: Pull Request resolved: #134 X-link: facebook/buck2-prelude#8 X-link: facebook/ocamlrep#23 Without the include dirs, the cgo command won't be able to find the header files causing `buck2 build` to fail. Reviewed By: krallin Differential Revision: D44788778 fbshipit-source-id: d1ed1a8ec2463aaba615844c0a3ff54158c1dc69
benbrittain
pushed a commit
to benbrittain/buck2
that referenced
this pull request
Apr 23, 2023
Summary: Pull Request resolved: facebook#134 X-link: facebook/buck2-prelude#8 X-link: facebook/ocamlrep#23 Without the include dirs, the cgo command won't be able to find the header files causing `buck2 build` to fail. Reviewed By: krallin Differential Revision: D44788778 fbshipit-source-id: d1ed1a8ec2463aaba615844c0a3ff54158c1dc69
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Without the include dirs, the cgo command won't be able to find the header files causing
buck2 buildto fail.Differential Revision: D44788778