Skip to content

Commit

Permalink
fix http archive extraction for compatible bsdtar binaries
Browse files Browse the repository at this point in the history
Summary:
- The `-P` flag seems necessary to extract through the UNC long path syntax. There is precedent for this, e.g. D51482034, D50643354
- cygwin tar also doesn't work, so we can opt to use the system tar instead. There is precedent for this, e.g. D51531469

Reviewed By: 8Keep

Differential Revision: D52856804

fbshipit-source-id: d8b5188657f54d902f1d95803cf948614e0c13d5
  • Loading branch information
jrodal98 authored and facebook-github-bot committed Jan 18, 2024
1 parent bc752d9 commit 18d14fd
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion prelude/http_archive/http_archive.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,9 @@ def _unarchive_cmd(
archive,
"--stdout",
"|",
"tar",
"%WINDIR%\\System32\\tar.exe",
"-x",
"-P",
"-f",
"-",
_tar_strip_prefix_flags(strip_prefix),
Expand Down

0 comments on commit 18d14fd

Please sign in to comment.