Skip to content

Commit

Permalink
io_uring: mark callbacks as noexcept
Browse files Browse the repository at this point in the history
Summary: Rather than forcing the IoUringBackend to deal with exceptions - push it to the callbacks like other async callbacks (eg folly::AsyncTransport)

Reviewed By: praihan, ycking21

Differential Revision: D37954822

fbshipit-source-id: 29c8079e4f8e5a40f6be02cd93e2b0e128804c55
  • Loading branch information
Dylan Yudaken authored and facebook-github-bot committed Sep 23, 2022
1 parent b8b05ff commit 7e99164
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions quic/server/QuicServerWorker.h
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ class QuicServerWorker : public folly::AsyncUDPSocket::ReadCallback,
}

// from EventRecvmsgCallback
EventRecvmsgCallback::MsgHdr* allocateData() override {
EventRecvmsgCallback::MsgHdr* allocateData() noexcept override {
auto* ret = msgHdr_.release();
if (!ret) {
ret = new MsgHdr(this);
Expand All @@ -493,7 +493,8 @@ class QuicServerWorker : public folly::AsyncUDPSocket::ReadCallback,
return ret;
}

EventRecvmsgMultishotCallback::Hdr* allocateRecvmsgMultishotData() override {
EventRecvmsgMultishotCallback::Hdr* allocateRecvmsgMultishotData() noexcept
override {
return new MultishotHdr(this);
}

Expand Down

0 comments on commit 7e99164

Please sign in to comment.