Support x_google_ignoreList in source map infra #973
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D43554204 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D43554204 |
motiz88
added a commit
to motiz88/metro
that referenced
this pull request
Apr 25, 2023
Summary: Pull Request resolved: facebook#973 Changelog: * **[Feature]**: Basic support for `x_google_ignoreList` in `metro-source-map` and `metro-symbolicate` Enables Metro's source map infrastructure to produce and consume the `x_google_ignoreList` field, documented [here](https://developer.chrome.com/blog/devtools-better-angular-debugging/#the-x_google_ignorelist-source-map-extension). An upcoming diff will use this infra support to add ignore lists to Metro's source maps by default. The changes here include: * An option to mark source files as ignored in `metro-source-map`'s `Generator` (used by the serializer). * Preserving ignore lists in `composeSourceMaps`. `composeSourceMaps` is used by React Native in [OSS](https://github.com/facebook/react-native/blob/c1304d938da9cd5016da0bded4d618c42efbd7e4/scripts/compose-source-maps.js#L13) to generate source maps for Hermes bytecode compiled from Metro bundles. * Including an `isIgnored` field in source locations returned via the `metro-symbolicate` API. `metro-symbolicate` is the reference implementation of symbolication based on Metro's source maps. Reviewed By: GijsWeterings Differential Revision: D43554204 fbshipit-source-id: f97255ec5272ad811e049c4db0c2ceca98dab3e2
motiz88
force-pushed
the
export-D43554204
branch
from
27bcbc6 to
f8b691c
Compare
Summary: Pull Request resolved: facebook#973 Changelog: * **[Feature]**: Basic support for `x_google_ignoreList` in `metro-source-map` and `metro-symbolicate` Enables Metro's source map infrastructure to produce and consume the `x_google_ignoreList` field, documented [here](https://developer.chrome.com/blog/devtools-better-angular-debugging/#the-x_google_ignorelist-source-map-extension). An upcoming diff will use this infra support to add ignore lists to Metro's source maps by default. The changes here include: * An option to mark source files as ignored in `metro-source-map`'s `Generator` (used by the serializer). * Preserving ignore lists in `composeSourceMaps`. `composeSourceMaps` is used by React Native in [OSS](https://github.com/facebook/react-native/blob/c1304d938da9cd5016da0bded4d618c42efbd7e4/scripts/compose-source-maps.js#L13) to generate source maps for Hermes bytecode compiled from Metro bundles. * Including an `isIgnored` field in source locations returned via the `metro-symbolicate` API. `metro-symbolicate` is the reference implementation of symbolication based on Metro's source maps. Reviewed By: GijsWeterings Differential Revision: D43554204 fbshipit-source-id: f49f65827ccb1d346eec192c81c53e39597025ab
|
This pull request was exported from Phabricator. Differential Revision: D43554204 |
motiz88
force-pushed
the
export-D43554204
branch
from
f8b691c to
10b7019
Compare
|
This pull request has been merged in d8ca3f2. |
fuxingloh
referenced
this pull request
in levaintech/keychain
Jun 20, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [metro](https://togithub.com/facebook/metro) | [`0.76.0` -> `0.76.6`](https://renovatebot.com/diffs/npm/metro/0.76.0/0.76.6) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [metro-resolver](https://togithub.com/facebook/metro) | [`0.76.0` -> `0.76.6`](https://renovatebot.com/diffs/npm/metro-resolver/0.76.0/0.76.6) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>facebook/metro</summary> ### [`v0.76.6`](https://togithub.com/facebook/metro/releases/tag/v0.76.6) [Compare Source](https://togithub.com/facebook/metro/compare/v0.76.5...v0.76.6) - **\[Types]** Update config and `Server` types to use broader types from `connect` package (facebook/metro@d20d7c8 by [@​huntie](https://togithub.com/huntie)) - **\[Types]** Fix TypeScript name for `createConnectMiddleware` export (facebook/metro@06682f8 by [@​huntie](https://togithub.com/huntie)) - **\[Deprecation]** Deprecate `server.enhanceMiddleware` option (facebook/metro@22e85fd by [@​huntie](https://togithub.com/huntie)) > NOTE: Experimental features are not covered by semver and can change at any time. - **\[Experimental]** Add `unstable_extraMiddleware` option to `runServer` API (facebook/metro@d0d5543 by [@​huntie](https://togithub.com/huntie)) **Full Changelog**: facebook/metro@v0.76.5...v0.76.6 ### [`v0.76.5`](https://togithub.com/facebook/metro/releases/tag/v0.76.5) [Compare Source](https://togithub.com/facebook/metro/compare/v0.76.4...v0.76.5) - **\[Feature]** Support URLs for both bundling and symbolication requests using `//&` instead of `?` as a query string delimiter (facebook/metro@bd357c8 by [@​robhogan](https://togithub.com/robhogan)) - **\[Fix]** Fix crash on a module added+modified+removed between updates (facebook/metro@5d7305e by [@​robhogan](https://togithub.com/robhogan)) - **\[Fix]** Fix missed modification on module removed+modified+added between updates (facebook/metro@5d7305e by [@​robhogan](https://togithub.com/robhogan)) - **\[Fix]** Emit source URLs in a format that will not be stripped by JavaScriptCore (facebook/metro@bce6b27ef8ac7c41e0a3e990eb71747cc0e6f606by [@​robhogan](https://togithub.com/robhogan)) - **\[Performance]** Prune unmodified modules from delta updates before sending them to the client (facebook/metro@e24c6ae by [@​robhogan](https://togithub.com/robhogan)) > NOTE: Experimental features are not covered by semver and can change at any time. - **\[Experimental]** Fix `babel/runtime` issue when using Package Exports (facebook/metro@905d773 by [@​huntie](https://togithub.com/huntie)) **Full Changelog**: facebook/metro@v0.76.4...v0.76.5 ### [`v0.76.4`](https://togithub.com/facebook/metro/releases/tag/v0.76.4) [Compare Source](https://togithub.com/facebook/metro/compare/v0.76.3...v0.76.4) - **\[Feature]**: Support the [`x_google_ignoreList`](https://developer.chrome.com/articles/x-google-ignore-list/) source map extension. ([https://github.com/facebook/metro/pull/973](https://togithub.com/facebook/metro/pull/973), [`82bd64a`](https://togithub.com/facebook/metro/commit/82bd64a9720174a9e2a02fb73bbef292153e20f1) by [@​motiz88](https://togithub.com/motiz88)) - **\[Feature]**: Support bundling KTX files as image assets. ([https://github.com/facebook/metro/pull/975](https://togithub.com/facebook/metro/pull/975) by [@​rshest](https://togithub.com/rshest)) - **\[Fix]**: Fix crash on a module added+modified+removed between updates. ([`5d7305e`](https://togithub.com/facebook/metro/commit/5d7305e2f3a9f5f4aebc889a452afb03b1db12a7) by [@​robhogan](https://togithub.com/robhogan)) - **\[Fix]**: Fix missed modification on module removed+modified+added between updates. ([`5d7305e`](https://togithub.com/facebook/metro/commit/5d7305e2f3a9f5f4aebc889a452afb03b1db12a7) by [@​robhogan](https://togithub.com/robhogan)) **Full Changelog**: facebook/metro@v0.76.3...v0.76.4 ### [`v0.76.3`](https://togithub.com/facebook/metro/releases/tag/v0.76.3) [Compare Source](https://togithub.com/facebook/metro/compare/v0.76.2...v0.76.3) - **\[Feature]**: Support custom `__loadBundleAsync` implementations in the default `asyncRequire` function. See the [lazy bundling RFC](https://togithub.com/react-native-community/discussions-and-proposals/blob/main/proposals/0605-lazy-bundling.md) for more details. (facebook/metro@ac3adce, facebook/metro@f07ce5c by [@​motiz88](https://togithub.com/motiz88)) - **\[Feature]**: Support `lazy` parameter in bundle requests. See the [lazy bundling RFC](https://togithub.com/react-native-community/discussions-and-proposals/blob/main/proposals/0605-lazy-bundling.md) for more details. (facebook/metro@4ef14f9 by [@​motiz88](https://togithub.com/motiz88)) - **\[Feature]**: Preserve comments in unminified builds, while continuing to strip all comments from minified builds. ([https://github.com/facebook/metro/pull/967](https://togithub.com/facebook/metro/pull/967) by [@​tido64](https://togithub.com/tido64)) - **\[Deprecated]**: The `transformer.asyncRequireModulePath` config option is deprecated. Use [`__loadBundleAsync`](https://togithub.com/react-native-community/discussions-and-proposals/blob/main/proposals/0605-lazy-bundling.md#\__loadbundleasync-in-metro) instead.(facebook/metro@c7b684f by [@​motiz88](https://togithub.com/motiz88)) > NOTE: Experimental features are not covered by semver and can change at any time. - **\[Experimental]** Package Exports unstable_conditionNames now defaults to \['require', 'import'] (facebook/metro@e70ceef by [@​huntie](https://togithub.com/huntie)) - **\[Experimental]** Removed `server.experimentalImportBundleSupport` config option. (facebook/metro@4ef14f9 by [@​motiz88](https://togithub.com/motiz88)) **Full Changelog**: facebook/metro@v0.76.2...v0.76.3 ### [`v0.76.2`](https://togithub.com/facebook/metro/releases/tag/v0.76.2) [Compare Source](https://togithub.com/facebook/metro/compare/v0.76.1...v0.76.2) - **\[Feature]**: Added customizeStack hook to Metro's `/symbolicate` endpoint to allow custom frame skipping logic on a stack level. (facebook/metro@ce266dd by [@​GijsWeterings](https://togithub.com/GijsWeterings)) - **\[Feature]**: Re-export `metro-core`'s `Terminal` from `metro`. (facebook/metro@86e3f93 by [@​robhogan](https://togithub.com/robhogan)) - **\[Feature]**: Re-export `metro-config`'s `resolveConfig` from `metro`. (facebook/metro@cc16664 by [@​robhogan](https://togithub.com/robhogan)) - **\[Types]**: Remove dependency on `@types/babel__code-frame`. (facebook/metro@41cdc03 by [@​robhogan](https://togithub.com/robhogan)) - **\[Types]**: Remove dependency on `@types/ws`. (facebook/metro@7deb525 by [@​robhogan](https://togithub.com/robhogan)) - **\[Types]**: Fix TypeScript types entry point for metro-source-map. (facebook/metro@3238bbc by [@​huntie](https://togithub.com/huntie)) - **\[Deprecated]**: Deprecate `ResolutionContext.getPackageForModule`. (facebook/metro@2d0a01c by [@​huntie](https://togithub.com/huntie)) > NOTE: Experimental features are not covered by semver and can change at any time. - **\[Experimental]**: Pass full path and query params to `asyncRequire` for lazy bundles. (facebook/metro@61a30b7 by [@​motiz88](https://togithub.com/motiz88)) - **\[Experimental]**: Fix bug where Package Exports warnings may have been logged for nested `node_modules` path candidates. (facebook/metro@29c77bf by [@​huntie](https://togithub.com/huntie)) - **\[Experimental]**: Fix `package.json` discovery against root package specifiers for Package Exports. (facebook/metro@b995303 by [@​huntie](https://togithub.com/huntie), fixes [https://github.com/facebook/metro/issues/965](https://togithub.com/facebook/metro/issues/965) reported by [@​shamilovtim](https://togithub.com/shamilovtim)) **Full Changelog**: facebook/metro@v0.76.1...v0.76.2 ### [`v0.76.1`](https://togithub.com/facebook/metro/releases/tag/v0.76.1) [Compare Source](https://togithub.com/facebook/metro/compare/v0.76.0...v0.76.1) - **\[Feature]**: Support custom transformer/resolver options in `metro build` and `runBuild` API. (facebook/metro@fcfecc9 by [@​motiz88](https://togithub.com/motiz88)) - **\[Feature]**: `metro get-dependencies --entryFile <entryFile>` can now be called as `metro get-dependencies <entryFile>`. (facebook/metro@6fdce04 by [@​huntie](https://togithub.com/huntie)) - **\[Feature]**: Add `Content-Type` and `Content-Length` headers for assets to Metro server. ([https://github.com/facebook/metro/pull/953](https://togithub.com/facebook/metro/pull/953) by [@​aleqsio](https://togithub.com/aleqsio), [https://github.com/facebook/metro/pull/961](https://togithub.com/facebook/metro/pull/961) by [@​byCedric](https://togithub.com/byCedric)) - **\[Feature]**: Expose `mergeConfig` util from `metro` package. (facebook/metro@aa8ec90 by [@​huntie](https://togithub.com/huntie)) - **\[Fix]**: `metro-file-map`: consistently abort crawl when `end()` is called. (facebook/metro@51877a8 by [@​motiz88](https://togithub.com/motiz88)) - **\[Fix]**: `metro-config`: Don't mutate argument to `loadConfig`. (facebook/metro@38ec62d by [@​motiz88](https://togithub.com/motiz88)) - **\[Fix]**: Babel transformers: Provide correct absolute source path to plugins when Metro is not run from the project root. (facebook/metro@de19bbd by [@​robhogan](https://togithub.com/robhogan)) - **\[Fix]**: [`resolver.assetExts`](https://facebook.github.io/metro/docs/configuration/#assetexts) will now match asset files for extension values that include a dot (`.`). (facebook/metro@6d65a32 by [@​huntie](https://togithub.com/huntie)) - **\[Fix]**: Don't register an [`unhandledRejection`](https://nodejs.org/api/process.html#event-unhandledrejection) listener, fix spammy EventEmitter leak warning. (facebook/metro@833f2ff by [@​motiz88](https://togithub.com/motiz88)) - **\[Types]**: Add bundled TypeScript definitions (partial) for all packages previously on DefinitelyTyped. (facebook/metro@c022c36, facebook/metro@07732e7, facebook/metro@9ee5280 by [@​huntie](https://togithub.com/huntie), with [@​afoxman](https://togithub.com/afoxman) and [@​tido64](https://togithub.com/tido64)) - **\[Types]**: Expose `MetroConfig` type in `metro` package. (facebook/metro@d2f3664 by [@​huntie](https://togithub.com/huntie)) > NOTE: Experimental features are not covered by semver and can change at any time. - **\[Experimental]**: Reorder `asyncRequire`'s parameters and make module name optional. (facebook/metro@4e5261c by [@​motiz88](https://togithub.com/motiz88)) - **\[Experimental]**: Remove experimental `metro-hermes-compiler` package. (facebook/metro@833f2ff by [@​motiz88](https://togithub.com/motiz88)) - **\[Experimental]**: Package Exports [`unstable_conditionNames`](https://facebook.github.io/metro/docs/configuration/#unstable_conditionnames-experimental) now defaults to `['require']`. ([https://github.com/facebook/metro/pull/955](https://togithub.com/facebook/metro/pull/955) by [@​huntie](https://togithub.com/huntie)) - **\[Experimental]**: Add compatibility with legacy Node.js "exports" array formats. (facebook/metro@f321cff, facebook/metro@1e47cb5 by [@​huntie](https://togithub.com/huntie)) **Full Changelog**: facebook/metro@v0.76.0...v0.76.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/levaintech/keychain). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMzEuMCIsInVwZGF0ZWRJblZlciI6IjM1LjEzMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced May 20, 2024
Open
Open
Open
Open
This was referenced May 28, 2024
Open
Open
Open
Open
Open
This was referenced Jun 5, 2024
Open
Open
](https://renovatebot.com){kind=link}
This was referenced Aug 14, 2024
Open
Open
Open
This was referenced Aug 30, 2024
Open
Open
Open
This was referenced Sep 7, 2024
Open
Open
This was referenced Sep 14, 2024
This was referenced Sep 21, 2024
Open
Open
This was referenced Sep 30, 2024
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
x_google_ignoreListinmetro-source-mapandmetro-symbolicateEnables Metro's source map infrastructure to produce and consume the
x_google_ignoreListfield, documented here.An upcoming diff will use this infra support to add ignore lists to Metro's source maps by default.
The changes here include:
metro-source-map'sGenerator(used by the serializer).composeSourceMaps.composeSourceMapsis used by React Native in OSS to generate source maps for Hermes bytecode compiled from Metro bundles.isIgnoredfield in source locations returned via themetro-symbolicateAPI.metro-symbolicateis the reference implementation of symbolication based on Metro's source maps.Differential Revision: D43554204