Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document unstable_perfLoggerFactory #920

Closed
wants to merge 1 commit into from
Closed

Document unstable_perfLoggerFactory #920

wants to merge 1 commit into from

Conversation

jacdebug
Copy link
Contributor

Summary: Adding documentation for unstable_perfLoggerFactory

Differential Revision: D42713103

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Jan 27, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42713103

@codecov-commenter
Copy link

Codecov Report

Base: 79.95% // Head: 79.95% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (0a02a75) compared to base (f785d4a).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #920      +/-   ##
==========================================
- Coverage   79.95%   79.95%   -0.01%     
==========================================
  Files         213      213              
  Lines       10772    10780       +8     
  Branches     2610     2610              
==========================================
+ Hits         8613     8619       +6     
- Misses       2159     2161       +2
Impacted Files Coverage Δ
packages/metro-config/src/defaults/index.js 91.30% <ø> (ø)
packages/metro-config/src/defaults/defaults.js 100.00% <100.00%> (ø)
packages/metro/src/Server.js 86.06% <0.00%> (-1.23%) ⬇️
packages/metro-file-map/src/index.js 88.83% <0.00%> (+0.72%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jacdebug @facebook-github-bot
Document unstable_perfLoggerFactory (facebook#920)
a3573d7 
Summary:
Pull Request resolved: facebook#920

Adding documentation for `unstable_perfLoggerFactory`

Differential Revision: D42713103

fbshipit-source-id: 42b350a5a2771e7fbb17d6369bba9feeac7e7311
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42713103

@jacdebug
Copy link
Contributor Author

Hey @EvanBacon @byCedric,

We pushed some cleanup’s this week and finally settled in name unstable_perfLoggerFactory for exposing logging. Changes are in main branch and will be part of next week metro release. This PR is for documenting unstable_perfLoggerFactory.

Note that unstable_perfLoggerFactory was called unstable_perfLogger before.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 11a4681.

@jacdebug jacdebug deleted the export-D42713103 branch January 30, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robhogan robhogan Awaiting requested review from robhogan

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacdebug @facebook-github-bot @codecov-commenter