Support fsevents
watcher on Apple silicon
#875
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If Watchman is unavailable or disabled, we try to fall back to
FSEventsWatcher
and then toNodeWatcher
.FSEventsWatcher
is only available ondarwin
, so werequire
it in a try/catch and swallow any error.This was hiding the fact that
fsevents
was also failing to load on Apple silicon:[email protected]
introduces support for Apple silicon. This updates to that version, and also adds Flow types based on the TypeScript types bundled withfsevents
so that Flow check passes ondarwin
(the Flow error wasuntyped-import
so the existingcannot-resolve-module
suppression doesn't work).Test plan
After: