[breaking] Turn off providesModuleNodeModules by default #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Sets the default value of `providesModuleNodeModules` to an empty array, since Haste is going away from RN. **This is a breaking change and metro and metro-config's major semver needs to be bumped.** Test Plan: Modify my copy of metro-config under RN so that `providesModuleNodeModules` defaults to an empty array, start the packager with `--reset-cache`, and load the RNTester bundle successfully.
ide
force-pushed
the
no-more-providesmodule
branch
from
212e5ec to
caa7ec7
Compare
12 tasks
|
cpojer is taking this even further with a grander sacrifice to the grim code reaper, closing this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is a draft PR until we completely replace Haste in RN.)
Summary
Sets the default value of
providesModuleNodeModulesto an empty array, since Haste is going away from RN. This is a breaking change and metro and metro-config's major semver needs to be bumped.Test plan
Modify my copy of metro-config under RN so that
providesModuleNodeModulesdefaults to an empty array, start the packager with--reset-cache, and load the RNTester bundle successfully.