-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix config in babel 7 #162
Conversation
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
==========================================
- Coverage 81.15% 81.13% -0.02%
==========================================
Files 126 126
Lines 4520 4522 +2
==========================================
+ Hits 3668 3669 +1
- Misses 852 853 +1
Continue to review full report at Codecov.
|
Summary: BREAKING CHANGE This change upgrades the React Native build pipeline from Babel 6 to Babel 7 If you use a `.babelrc` then you'll need to update it to Babel 7 (note that some plugins are no longer relevant, some plugins are automatically upgraded, and some will need some manual love). Note that you may also need to upgrade your dev env, tests etc, to make sure they work with Babel 7. Reviewed By: mjesun Differential Revision: D7591303 fbshipit-source-id: 29cef21f6466633a9c366d1f3c0d3cf874c714db
@rafeca Can you review this pr ? Thanks. |
@qfox Can you take a look at this pr, set options on preprocessor won't work. |
@gengjiawen this problem should be resolved once the lockdown lands. For now your workaround is to manually and explicitly install babel at 7.0.0-beta.40 These api changes were added later (which is why they slipped under our radar). The lockdown fixes will hopefully be published in a new version today. Note that if you still require the BABEL_VERSION flag to be set at all then you're using an older version of Metro. Regardless, to fix the option problem you'll need to wait a few hours. Working hard on it. |
Okay, but add options like this facebook/react-native@da57ae7 won't work, because inside metro won't accept option like this. |
I hope we can fix the ci thing soon :) |
@qfox is this PR still relevant with your latest changees? |
Summary
Fix ast is null in babel 7, see facebook/react-native@f8d6b97#r28647044.
change sourceType to "unambiguous", see facebook/react-native@f8d6b97#r28569395.
With those change, react native can fix all jest test.
Test plan
pass react native test-ci task.