Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix or filter with a comment windows tests and run CI tests on windows and macOS #1373

Closed
wants to merge 1 commit into from
Closed

fix or filter with a comment windows tests and run CI tests on windows and macOS #1373

wants to merge 1 commit into from

Conversation

vzaidman
Copy link
Contributor

@vzaidman vzaidman commented Oct 15, 2024 •
edited
Loading

Summary

  • Make tests pass on by fixing 2 tests files and ignoring 27 test files categorized into 4 categories of reasons for their failure.
  • This allows us to run on CI 1308 tests on across 96 files on Windows ignoring around 700 tests (64% out of the 2038 tests that pass on macOS)
  • Run tests on MacOS as well, meaning that the tests will now run on Ubuntu, Windows, MacOS

Changelog: [Internal]

Test plan

yarn jest on Windows.
image

CI passes, testing on Windows, Linux, and MacOS:

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 15, 2024
@vzaidman vzaidman force-pushed the make-nightlies-pass-on-windows branch from 8fe6d7e to 9e77353 Compare October 15, 2024 17:01
@facebook-github-bot
Copy link
Contributor

@vzaidman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@vzaidman vzaidman changed the title fix or ignore with a comment windows tests and run tests on Windows on CI fix or filter with a comment windows tests and run CI tests on windows Oct 15, 2024
@vzaidman vzaidman changed the title fix or filter with a comment windows tests and run CI tests on windows fix or filter with a comment windows tests and run CI tests on windows and macOS Oct 17, 2024
@vzaidman vzaidman mentioned this pull request Oct 17, 2024
Closed
@vzaidman vzaidman force-pushed the make-nightlies-pass-on-windows branch 2 times, most recently from 68a667a to 4e2c497 Compare October 17, 2024 09:05
@vzaidman vzaidman force-pushed the make-nightlies-pass-on-windows branch from 4e2c497 to 073914f Compare October 17, 2024 09:38
@facebook-github-bot
Copy link
Contributor

@vzaidman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@vzaidman merged this pull request in 6ba55f9.

@vzaidman vzaidman deleted the make-nightlies-pass-on-windows branch October 17, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vzaidman @facebook-github-bot