Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip certain tests when installing yarn ignoring the lockfile #1369

Closed
wants to merge 2 commits into from
Closed

Skip certain tests when installing yarn ignoring the lockfile #1369

wants to merge 2 commits into from

Conversation

vzaidman
Copy link
Contributor

@vzaidman vzaidman commented Oct 10, 2024 •
edited
Loading

  1. Allows to create a filter file to programmatically skip selected tests
  2. Uses that filter file to skip the babel types tests on nightlies that is currently failing
  3. The next diff will skip certain tests on Windows so the rest of them can run and pass until all Windows tests are fixed.

Test:
Before:

After:

  • Nightlies DO pass on this branch since they are ignoring the test Babel Flow library definitions should be up to date.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 10, 2024
@vzaidman vzaidman force-pushed the skip-certain-tests-on-yarn-install-no-lockfile branch from 51aeb5a to 176a592 Compare October 10, 2024 12:03
@vzaidman vzaidman force-pushed the skip-certain-tests-on-yarn-install-no-lockfile branch 4 times, most recently from 7822b00 to ab12773 Compare October 11, 2024 09:04
@facebook-github-bot
Copy link
Contributor

@vzaidman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@vzaidman vzaidman changed the title [WIP] skip certain tests when installing yarn ignoring the lockfile Skip certain tests when installing yarn ignoring the lockfile Oct 11, 2024
@vzaidman vzaidman force-pushed the skip-certain-tests-on-yarn-install-no-lockfile branch 2 times, most recently from 61c3b16 to 1da4cc5 Compare October 11, 2024 09:16
@facebook-github-bot
Copy link
Contributor

@vzaidman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@vzaidman vzaidman force-pushed the skip-certain-tests-on-yarn-install-no-lockfile branch from 1da4cc5 to 63c3957 Compare October 14, 2024 11:45
@facebook-github-bot
Copy link
Contributor

@vzaidman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@vzaidman vzaidman force-pushed the skip-certain-tests-on-yarn-install-no-lockfile branch from 63c3957 to fac2e0f Compare October 15, 2024 10:33
@vzaidman vzaidman force-pushed the skip-certain-tests-on-yarn-install-no-lockfile branch from fac2e0f to 275361a Compare October 15, 2024 10:46
@facebook-github-bot
Copy link
Contributor

@vzaidman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@vzaidman merged this pull request in 4e5bd94.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robhogan robhogan Awaiting requested review from robhogan

@huntie huntie Awaiting requested review from huntie

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vzaidman @facebook-github-bot