Implement module-level memoization of inlined requires #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
A performance optimisation for `inlineRequries`, where we replace `const foo = require('./foo')` at top level with `var foo`, and replace subsequent references to `foo` with `(foo || foo = require('./foo')`.
This differs from plain `inlineRequires` by the use of the memo variable, which (for modules that don't return a falsy value) saves calling into `require`, backed by `metroRequire`, and retrieving the previously-initialised module from a `Map` by its numeric ID.
```
- **[Experimental]:** Implement `transformer.unstable_memoizeInlineRequires` to optimise inlined access.
```
Reviewed By: javache
Differential Revision: D62125134
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62125134 |
|
This pull request has been merged in f35992c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
A performance optimisation for
inlineRequries, where we replaceconst foo = require('./foo')at top level withvar foo, and replace subsequent references tofoowith(foo || foo = require('./foo').This differs from plain
inlineRequiresby the use of the memo variable, which (for modules that don't return a falsy value) saves calling intorequire, backed bymetroRequire, and retrieving the previously-initialised module from aMapby its numeric ID.Reviewed By: javache
Differential Revision: D62125134