fix native fetch error in server-test on node 18 #1341
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@vzaidman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
vzaidman
force-pushed
the
fix-node-18-fetch-error
branch
from
f9c941d to
f7dfb0c
Compare
|
@vzaidman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
vzaidman
force-pushed
the
fix-node-18-fetch-error
branch
from
f7dfb0c to
56382c4
Compare
|
@vzaidman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
vzaidman
force-pushed
the
fix-node-18-fetch-error
branch
from
56382c4 to
1506b80
Compare
|
@vzaidman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
vzaidman
force-pushed
the
fix-node-18-fetch-error
branch
from
1506b80 to
0bc9b51
Compare
|
@vzaidman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing node 18 fetch error due to attempt to set the "Connection" header which is not supported on that version of node (nodejs/undici#1305).
However "Connection" is set to "close" by default in node 18 anyway comparing with later version so we just don't touch it on that version.
Test plan
yarn jest packages/metro/src/integration_tests/__tests__/server-test.jsTested ad hoc on Node JS versions:
18.0.018.14.118.14.2Plus the versions in the github actions