Skip to content

Commit

Permalink
Remove check for isEndToEndTestRun from registering to keyHandler
Browse files Browse the repository at this point in the history
Summary: This fundamentally changes the semantics of state when doing e2e test runs and wasn't correct to add.

Reviewed By: muraziz

Differential Revision: D13415386

fbshipit-source-id: b4d21622f898e78873554bbe740b524293b24408
  • Loading branch information
astreet authored and facebook-github-bot committed Dec 11, 2018
1 parent 3a16417 commit 9836497
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion litho-core/src/main/java/com/facebook/litho/Component.java
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,7 @@ private void applyStateUpdates(ComponentContext c) {
if (ComponentsConfiguration.isDebugModeEnabled || ComponentsConfiguration.useGlobalKeys) {
final KeyHandler keyHandler = getScopedContext().getKeyHandler();
// This is for testing, the keyHandler should never be null here otherwise.
if (keyHandler != null && !ComponentsConfiguration.isEndToEndTestRun) {
if (keyHandler != null) {
keyHandler.registerKey(this);
}
}
Expand Down

0 comments on commit 9836497

Please sign in to comment.