feat: upgrade to JSDOM 16

[lh0x00]

Summary

Fix #9507 by using new version of jsdom. PR should be merged to jest@26 or a jest version supported node >= 10 (a requirement in jsdom).

Test plan

Green CI with node >= 10 and write new e2e tests to check leaking memory.

[SimenB]

We'll want getVmContext as well https://github.com/SimenB/jest-environment-jsdom-sixteen/blob/fd898842676e8f888feddbf4c4af81a3517e0306/index.js#L104

[lh0x00]

I added getVmContext and it seems tests is passed (node >= 10).

[SimenB]

The circus run complains about a memory leak. Is it correct or flake?

[lh0x00]

It's ok because we know jest-circus is leaking by self, ref #8816.

[irega]

With the last change, I guess the PR it's ready to review @SimenB @mindblight

Thanks so much!

[SimenB]

As mentioned multiple times before, this cannot be merged until we're ready to make breaking changes, which we're not at the moment. It requires dropping node 8.

This PR also introduces a memory leak

[vibaiher]

Since jsdom 16 adds support to custom elements, this PR also enables users to test their custom web components like this:

import MyCustomElement from './MyCustomElement'

describe('Playlist', () => {
    beforeEach(() => {
        window.customElements.define('my-custom-element', MyCustomElement)
    })

    it('attributes are empty by default', () => {
        const customElement = document.createElement('my-custom-element')
        
        customElement.setAttribute('title', 'My Custom Title')

        expect(customElement.shadowRoot.querySelector('.title').innerHTML).toBe('My Custom Title')
    })
})

[AviVahl]

[email protected] has memory and handle leak fixes that might be relevant to this PR.

[SimenB]

This should be rebased now that we've fixed the memory leak in circus.

EDIT: I merged in master now

[SimenB]

Note to self, remember to merge #9938 after landing this

[cpojer]

Nice!

[ExE-Boss]

This change is wrong, since it causes the newly‑created global to have the ArrayBuffer constructor from the outer realm, whereas jsdom/jsdom@3a4fd62 made it so that the inner realm has its own ArrayBuffer constructor and prototype chain.

---

Refs: #10786, #10854

[SimenB]

@ExE-Boss great! Wanna send a PR?

[ExE-Boss]

@SimenB #10885

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.